Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#2485 closed enhancement (fixed)

[patch][cla]BiDi enable Menu2 widget

Reported by: Adam Peller Owned by: Adam Peller
Priority: high Milestone: 0.9
Component: Widgets Version: 0.4.1
Keywords: bidi Cc: bill, alex
Blocked By: Blocking:

Description

My first attempt to BiDi? enable a widget. Menu2 seems reasonably straightforward, and happily dojo.html did just what I needed.

One piece remaining is to flip the submenu arrow images and find a way to conditionally reference the new set based on dojo.html.isLeftToRight...

Attachments (5)

menu2-bidi-src.patch (8.3 KB) - added by Adam Peller 12 years ago.
bidi enable menu2 widget
menu2-bidi-test.patch (14.7 KB) - added by Adam Peller 12 years ago.
test by setting html dir="rtl". Translations welcome.
submenu_disabled_rtl.gif (53 bytes) - added by Adam Peller 12 years ago.
submenu_off_rtl.gif (827 bytes) - added by Adam Peller 12 years ago.
submenu_on_rtl.gif (97 bytes) - added by Adam Peller 12 years ago.

Download all attachments as: .zip

Change History (9)

Changed 12 years ago by Adam Peller

Attachment: menu2-bidi-src.patch added

bidi enable menu2 widget

Changed 12 years ago by Adam Peller

Attachment: menu2-bidi-test.patch added

test by setting html dir="rtl". Translations welcome.

comment:1 Changed 12 years ago by bill

Looks fine to me. You must have been working with Alex on this; 90% of the changes are about formatting :-). I assume this is against the latest code? Check it in quickly because I'm about to port Menu2 over to dijit.

comment:2 Changed 12 years ago by bill

PS: About the arrow position: I assume there will just be two templates, one for LTR and one for RTL.

Changed 12 years ago by Adam Peller

Attachment: submenu_disabled_rtl.gif added

Changed 12 years ago by Adam Peller

Attachment: submenu_off_rtl.gif added

Changed 12 years ago by Adam Peller

Attachment: submenu_on_rtl.gif added

comment:3 Changed 12 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [7403]) Enable BiDi? for Menu2 widget. Fixes #2485

comment:4 Changed 12 years ago by Adam Peller

Keywords: bidi added
Note: See TracTickets for help on using tickets.