#2485 closed enhancement (fixed)
[patch][cla]BiDi enable Menu2 widget
| Reported by: | Adam Peller | Owned by: | Adam Peller |
|---|---|---|---|
| Priority: | high | Milestone: | 0.9 |
| Component: | Widgets | Version: | 0.4.1 |
| Keywords: | bidi | Cc: | bill, alex |
| Blocked By: | Blocking: |
Description
My first attempt to BiDi? enable a widget. Menu2 seems reasonably straightforward, and happily dojo.html did just what I needed.
One piece remaining is to flip the submenu arrow images and find a way to conditionally reference the new set based on dojo.html.isLeftToRight...
Attachments (5)
Change History (9)
Changed 13 years ago by
| Attachment: | menu2-bidi-src.patch added |
|---|
Changed 13 years ago by
| Attachment: | menu2-bidi-test.patch added |
|---|
test by setting html dir="rtl". Translations welcome.
comment:1 Changed 13 years ago by
Looks fine to me. You must have been working with Alex on this; 90% of the changes are about formatting :-). I assume this is against the latest code? Check it in quickly because I'm about to port Menu2 over to dijit.
comment:2 Changed 13 years ago by
PS: About the arrow position: I assume there will just be two templates, one for LTR and one for RTL.
Changed 13 years ago by
| Attachment: | submenu_disabled_rtl.gif added |
|---|
Changed 13 years ago by
| Attachment: | submenu_off_rtl.gif added |
|---|
Changed 13 years ago by
| Attachment: | submenu_on_rtl.gif added |
|---|
comment:3 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:4 Changed 13 years ago by
| Keywords: | bidi added |
|---|
Note: See
TracTickets for help on using
tickets.
bidi enable menu2 widget