Opened 13 years ago

Closed 12 years ago

#2463 closed enhancement (wontfix)

[PATCH] [CLA] Allow DropDownDate/TimePicker to be skinned (templatePath & templateCssPath)

Reported by: vdemay@… Owned by: anonymous
Priority: high Milestone:
Component: Dijit Version: 0.4.1
Keywords: Cc: vdemay@… tk
Blocked By: Blocking:

Description

DropDownDatePicker? & DropDownTimePicker? can not be skinned using template[Css]Path. The fallowing allows to set Template[Css]Path on the innner Date|TimePicker? :

Index: /Users/doume/Dev/Wicket/branch-1X/wicket-contrib-dojo/src/main/java/wicket/contrib/dojo/dojo-0.4/src/widget/DropdownDatePicker.js
===================================================================
--- /Users/doume/Dev/Wicket/branch-1X/wicket-contrib-dojo/src/main/java/wicket/contrib/dojo/dojo-0.4/src/widget/DropdownDatePicker.js	(revision 1765)
+++ /Users/doume/Dev/Wicket/branch-1X/wicket-contrib-dojo/src/main/java/wicket/contrib/dojo/dojo-0.4/src/widget/DropdownDatePicker.js	(working copy)
@@ -92,6 +92,9 @@
 		//	disable all incremental controls, must pick a date in the current display
 		staticDisplay: false,
 		
+		templatePath:  dojo.uri.dojoUri("src/widget/templates/DatePicker.htm"),
+		templateCssPath:  dojo.uri.dojoUri("src/widget/templates/DatePicker.css"),
+		
 		postMixInProperties: function(localProperties, frag){
 			// summary: see dojo.widget.DomWidget
 
@@ -116,10 +119,14 @@
 			// summary: see dojo.widget.DomWidget
 			dojo.widget.DropdownDatePicker.superclass.fillInTemplate.call(this, args, frag);
 			//attributes to be passed on to DatePicker
+			
 			var dpArgs = {widgetContainerId: this.widgetId, lang: this.lang, value: this.value,
 				startDate: this.startDate, endDate: this.endDate, displayWeeks: this.displayWeeks,
-				weekStartsOn: this.weekStartsOn, adjustWeeks: this.adjustWeeks, staticDisplay: this.staticDisplay};
-
+				weekStartsOn: this.weekStartsOn, adjustWeeks: this.adjustWeeks, staticDisplay: this.staticDisplay, 
+				templateCssPath:  this.templateCssPath, templatePath: this.templatePath
+				};
+			
+			
 			//build the args for DatePicker based on the public attributes of DropdownDatePicker
 			this.datePicker = dojo.widget.createWidget("DatePicker", dpArgs, this.containerNode, "child");
 			dojo.event.connect(this.datePicker, "onValueChanged", this, "onSetDate");
Index: /Users/doume/Dev/Wicket/branch-1X/wicket-contrib-dojo/src/main/java/wicket/contrib/dojo/dojo-0.4/src/widget/DropdownTimePicker.js
===================================================================
--- /Users/doume/Dev/Wicket/branch-1X/wicket-contrib-dojo/src/main/java/wicket/contrib/dojo/dojo-0.4/src/widget/DropdownTimePicker.js	(revision 1765)
+++ /Users/doume/Dev/Wicket/branch-1X/wicket-contrib-dojo/src/main/java/wicket/contrib/dojo/dojo-0.4/src/widget/DropdownTimePicker.js	(working copy)
@@ -53,6 +53,10 @@
 		
 		// 	name of the form element, used to create a hidden field by this name for form element submission.
 		name: "",
+		
+		
+		templatePath: dojo.uri.dojoUri("src/widget/templates/TimePicker.htm"),
+		templateCssPath: dojo.uri.dojoUri("src/widget/templates/TimePicker.css"),
 
 		postMixInProperties: function() {
 			dojo.widget.DropdownTimePicker.superclass.postMixInProperties.apply(this, arguments);
@@ -63,7 +67,10 @@
 		fillInTemplate: function(){
 			dojo.widget.DropdownTimePicker.superclass.fillInTemplate.apply(this, arguments);
 
-			var timeProps = { widgetContainerId: this.widgetId, lang: this.lang };
+			var timeProps = { widgetContainerId: this.widgetId, lang: this.lang , 
+				templateCssPath:  this.templateCssPath, templatePath: this.templatePath
+				};
+			
 			this.timePicker = dojo.widget.createWidget("TimePicker", timeProps, this.containerNode, "child");
 			dojo.event.connect(this.timePicker, "onSetTime", this, "onSetTime");
 			dojo.event.connect(this.inputNode,  "onchange",  this, "onInputChange");

Change History (6)

comment:1 Changed 13 years ago by tk

Cc: vdemay@… added
Type: defectenhancement

Do you have a CLA on file, this is a nice catch, I cant believe it wasnt mentioned earlier...

comment:2 Changed 13 years ago by tk

Cc: vdemay@… added; vdemay@… removed

comment:3 Changed 13 years ago by vdemay@…

Hi, I've already sent you a CLA with vincent.demay@… email adress, is it ok or do you want me to sign an other one

comment:4 Changed 13 years ago by tk

CLA's are tracked by name not email, so I just needed find out if you had one submitted. I'll see if I can find it on the list we have now. Thanks

comment:5 Changed 13 years ago by tk

Summary: [PATCH]Allow DropDownDate/TimePicker to be skinned (templatePath & templateCssPath)[PATCH] [CLA] Allow DropDownDate/TimePicker to be skinned (templatePath & templateCssPath)

comment:6 Changed 12 years ago by Adam Peller

Component: GeneralDijit
Resolution: wontfix
Status: newclosed

The new Dijit version of the DropdownDatePicker? and Calendar widgets should be skinnable under the new CSS scheme. There is no TimePicker?, yet.

Note: See TracTickets for help on using tickets.