Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#243 closed defect (fixed)

LayoutPane doesn't work if margins specified indirectly via class attribute

Reported by: bill Owned by: anonymous
Priority: high Milestone:
Component: Widgets Version: 0.1
Keywords: Cc:
Blocked By: Blocking:

Description

IE6 problem. Define a margin in CSS class and then reference it like this:

.error_area {

border: red 4px solid; padding: 0.5em; margin-left: 1em; margin-right: 2em; margin-top: 0.5em; margin-bottom: 0.5em; background-color: #f6f6fa;

}

<div dojoType="LayoutPane?" layoutAlign="top" class="error_area">

This calls dojo.style.getOuterHeight(id) --> getMarginHeight() --> getPixelValue() --> getUnitValue() --> returns "auto" (rather than a number)

"auto" becomes NaN thus breaking LayoutPane?.

Change History (3)

comment:1 Changed 14 years ago by bill

Turns out that margins aren't working at all in LayoutPane?. They have always been ignored. (The code acts as though the margin is 0, even when it isn't.)

As of #2673, the style code returns 0 rather than NaN, but of course this doesn't work for cases when the user has specified margin.

comment:2 Changed 14 years ago by bill

Resolution: fixed
Status: newclosed

OK, working as of rev 3445 and test checked into test_LayoutContainer.html

comment:3 Changed 13 years ago by (none)

Milestone: 0.3release

Milestone 0.3release deleted

Note: See TracTickets for help on using tickets.