Opened 13 years ago

Closed 8 years ago

#2429 closed defect (wontfix)

intern-strings should ignore code in comments

Reported by: James Burke Owned by: James Burke
Priority: low Milestone: future
Component: BuildSystem Version: 0.4.1
Keywords: Cc: Rawld Gill
Blocked By: Blocking:

Description (last modified by James Burke)

Right now, intern-strings will try to intern resources even if they are in a comment, like:

//templateCssPath: dojo.uri.dojoModuleUri("dojo.widget", "templates/FooButton.css"),

Change History (8)

comment:1 Changed 12 years ago by Adam Peller

Component: GeneralBuildSystem
Owner: changed from anonymous to James Burke

comment:2 Changed 12 years ago by James Burke

Milestone: 0.91.0

Moving to 1.0, not the optimal behavior, but if you use a shrink-safed file or the comment-stripped file (optimize=shrinksafe or optimize=comments for the 0.9 build), the commented out stuff goes away.

comment:3 Changed 12 years ago by James Burke

Milestone: 1.02.0

comment:4 Changed 12 years ago by alex

Milestone: 2.01.3

Milestone 2.0 deleted

comment:5 Changed 11 years ago by James Burke

Description: modified (diff)
Milestone: 1.3future

comment:6 Changed 8 years ago by ben hockey

Cc: rawld added
Keywords: needsreview added
Priority: highlow

with the dojo/text plugin I believe this is no longer a concern

comment:7 Changed 8 years ago by ben hockey

Cc: Rawld Gill added; rawld removed

comment:8 Changed 8 years ago by bill

Keywords: needsreview removed
Resolution: wontfix
Status: newclosed

I agree, this should be a wontfix as the whole dojo.cache() thing isn't being used anymore.

Note: See TracTickets for help on using tickets.