Changes between Version 1 and Version 2 of Ticket #2414


Ignore:
Timestamp:
Feb 24, 2007, 7:46:54 PM (13 years ago)
Author:
alex
Comment:

Josh, Adam, great patch.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2414

    • Property Status changed from new to assigned
  • Ticket #2414 – Description

    v1 v2  
    11The attached patch (and test) clears up several problems with dojo.lang.reduce:
    22
    3 * the "lenght" typo
    4 * the fact that the arr.shift() is destructive on the argument passed in
    5 * removes bloat to check for an invalid call of arg length = 1
    6 * arg length 3 and the default case seem to be redundant
    7 * reorders the arg list to be more sane and reduce the code and api complexity (we can get away with it in 0.9)
     3 * the "lenght" typo
     4 * the fact that the arr.shift() is destructive on the argument passed in
     5 * removes bloat to check for an invalid call of arg length = 1
     6 * arg length 3 and the default case seem to be redundant
     7 * reorders the arg list to be more sane and reduce the code and api complexity (we can get away with it in 0.9)
    88
    99I don't understand the history here so I'm assigning to Alex for review.