Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#2404 closed enhancement (fixed)

intern-strings should intern all strings in widget files

Reported by: James Burke Owned by: James Burke
Priority: high Milestone:
Component: BuildSystem Version: 0.4.1
Keywords: Cc:
Blocked By: Blocking:

Description

Right now, when intern-strings is run, only dojo.js and the .xd.js files get strings interned. However, the normal .js files that are not part of dojo.js should also have strings interned too, just as we flatten all resource bundles to improve load speed of builds.

Change History (3)

comment:1 Changed 13 years ago by James Burke

Resolution: fixed
Status: newclosed

(In [7186]) Fixes #2301 and #2404, and references #2366. web built dojo.js now has strings interned, and for regular builds, all widget js files have strings interned now for the intern-strings target. To get those things to work, I moved the internStrings.js functions into buildUtil.js, but I did it slightly differently than the patch in #2301.

comment:2 Changed 13 years ago by James Burke

Resolution: fixed

(In [7187]) (merge from 0.4 branch) Fixes #2301 and #2404, and references #2366. web built dojo.js now has strings interned, and for regular builds, all widget js files have strings interned now for the intern-strings target. To get those things to work, I moved the internStrings.js functions into buildUtil.js, but I did it slightly differently than the patch in #2301.

comment:3 Changed 12 years ago by (none)

Milestone: 0.4.2

Milestone 0.4.2 deleted

Note: See TracTickets for help on using tickets.