Opened 12 years ago

Closed 12 years ago

#2387 closed defect (wontfix)

FilteringTable removes existing classes when sorting

Reported by: rodeoclown@… Owned by: Tom Trenka
Priority: high Milestone: 0.9
Component: Dijit Version: 0.4.1
Keywords: filteringTable classes Cc:
Blocked By: Blocking:

Description

FilteringTable? uses dojo.html.setClass() to set the classes on the header. This will remove any existing classes when a table header is selected.

I cannot add a patch at this time (no CLA yet), but my suggested fix is to replace the setClass() with a removeClass() call to remove the now unused class (so remove headerUpClass before adding headerDownClass etc) and use an addClass() call rather than setClass().

This will keep the table working correctly and leave any other styles alone.

Change History (5)

comment:1 Changed 12 years ago by rodeoclown@…

That last suggestion will fix the headers, but not the classes set on "td"s. Someone else has asked about this here: http://blog.dojotoolkit.org/2006/08/17/new-widget-filteringtable#comment-959 with no response.

comment:2 Changed 12 years ago by Tom Trenka

Owner: changed from anonymous to Tom Trenka

comment:3 Changed 12 years ago by Tom Trenka

Component: GeneralWidgets

comment:4 Changed 12 years ago by bill

Component: WidgetsDijit
Milestone: 0.9

This will all be redone for the new Table widget so presumably this won't be an issue anymore, but I'll leave the bug open until that widget is completed, as a reminder to check this issue.

comment:5 Changed 12 years ago by Tom Trenka

Resolution: wontfix
Status: newclosed

FilteringTable? is not being ported to either Dijit or DojoX, so I'm closing the bug.

Note: See TracTickets for help on using tickets.