Opened 15 years ago
Closed 15 years ago
#2372 closed defect (invalid)
AccordionContainer + bigger than oneline labels = bug when not selected
Reported by: | joose | Owned by: | Adam Peller |
---|---|---|---|
Priority: | high | Milestone: | |
Component: | Dijit | Version: | 0.4.1 |
Keywords: | AccordionContainer label | Cc: | |
Blocked By: | Blocking: |
Description
When label is bigger than one line, then not-selected accordionpanes has wrong background. Tested with Firefox and Safari
Attachments (1)
Change History (7)
Changed 15 years ago by
Attachment: | accordion.patch added |
---|
comment:1 Changed 15 years ago by
Seems that there still is a bug, for AccordionContainer? countring position of the labels wrongly when they are minimized. Try makeing more than one label have bigger labels.
comment:2 Changed 15 years ago by
Did little more testing: AccordionPane?.getLabelHeight() returns wrong height when there is image making label bigger.
comment:3 Changed 15 years ago by
Found the problem: Problem is that labelHeight is calculated when images in the labels are not yet loaded -> wrong height of the label.
Solutions?
- define height to all images in label
- make accordion somehow know when images are loaded and THEN calculate height.
- Other?
comment:4 Changed 15 years ago by
Component: | Widgets → Dijit |
---|---|
Owner: | changed from bill to koranteng |
comment:5 Changed 15 years ago by
Owner: | changed from koranteng to Adam Peller |
---|
Need a test case. The comments seem to imply that an image in the accordion title is required to see this bug? I think adding code to handle image load events seems a bit heavyweight, and I'd be tempted to go with your #1 (or #3 have the user wire up image onload events and trigger a layout, perhaps?)
comment:6 Changed 15 years ago by
Resolution: | → invalid |
---|---|
Status: | new → closed |
ok, I tested multi-line labels (the originally reported bug) and it seems to work fine now. If images are a problem, a test case is needed and we might need to document our way out of that one with a workaround, unless a cheap workaround can be found.
Patch to fix this bug