Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#237 closed defect (fixed)

in build.xml, the property "copyright" needs (1) a line feed, and maybe (2) a mention of the BSD license

Reported by: Brian Douglas Skinner <openrecord@…> Owned by: anonymous
Priority: high Milestone:
Component: BuildTools Version: 0.1
Keywords: Cc:
Blocked By: Blocking:

Description

In the dojo-0.1.0 release, the files in zip-file "editions" had single-line copyright statements at the top of every source file: /* Copyright (c) 2004-2005 The Dojo Foundation, Licensed under the Academic Free License version 2.1 or above */

In dojo-0.1.0 that copyright line was missing a line feed at the end, which made it hard to read the code. For example, the beginning of the src extString.js file looked like this:

/* Copyright (c) 2004-2005 The Dojo Foundation, Licensed under the Academic Free License version 2.1 or above */dojo.provide("dojo.text.String");

It would be better if it looked like this: /* Copyright (c) 2004-2005 The Dojo Foundation, Licensed under the Academic Free License version 2.1 or above */ dojo.provide("dojo.text.String");

Or, better still: /* Copyright (c) 2004-2005 The Dojo Foundation, Licensed under the Academic Free License version 2.1 or above */

dojo.provide("dojo.text.String");

Probably that line of text needs to get changed for release 0.2.0 anyway, to mention BSD as well as AFL. It'd be easy to add in the line feed character at the same time.

I think the place to make the change is line 37 in buildscriptsuild.xml

Change History (2)

comment:1 Changed 14 years ago by alex

Resolution: fixed
Status: newclosed

fixed in rev [2376]

comment:2 Changed 12 years ago by (none)

Milestone: 0.2release

Milestone 0.2release deleted

Note: See TracTickets for help on using tickets.