Getting "Invalid Date" with dojo.date.setIso8601() with Firefox

[Adam Peller]

Reported by Akira Sudoh (IBM)

When calling dojo.date.setIso8601(new Date, "20070116T141500+09") with Firefox, it returns "Invalid Date".

My investigation indicated that dojo.date code does not consider regular expression tokens being "undefined", which happens with Firefox, when there is no string to match to the token. (Internet Explorer sets null string to such tokens)

In this specific case, dojo.date.setIso8601 performs match a string "20070116T141500+09" to a regular expression "Z|(([-+])([0-9]{2})(:?([0-9]{2}))?)$". And it'll be tokenized as:

0: "20070116T141500+09" 1: "+09" 2: "+" 3: "09" 4: undefined 5: undefined

The token in question is the fifth one, which will be used to calculate timezone offset, using Number(). Number(undefined) returns NaN and that causes "Invalid Date".

I've attached sample HTML to reproduce this and the patch.

[Adam Peller]

Test case from Akira

[Adam Peller]

patch from Akira Sudoh (IBM)

[Adam Peller]

proposed patch to dojo.date.serialize

[Adam Peller]

(In [7042]) Fixes #2338. Use

instead of ?: -- works fine in Rhino now.