Opened 13 years ago

Closed 13 years ago

#2322 closed defect (fixed)

dojo.math (now?) required for FilteringTable

Reported by: dojo@… Owned by: Tom Trenka
Priority: high Milestone: 0.9
Component: Widgets Version: 0.4.1
Keywords: Cc: ttrenka@…
Blocked By: Blocking:

Description

The nightly build of FilteringTable? now appears to need a require of "dojo.math" to be able to function with decimal numbers.

Change History (5)

comment:1 Changed 13 years ago by dylan

Milestone: 0.9
Owner: changed from bill to Tom Trenka

comment:2 Changed 13 years ago by Tom Trenka

Resolution: invalid
Status: newclosed

Not following how this is a defect, nor why it's a high priority; IIRC it's part of Adam Peller's efforts to implement internationalization with numeric formatting, which is part of an older bug.

Marking this as invalid.

comment:3 Changed 13 years ago by bill

Resolution: invalid
Status: closedreopened

FilteringTable? references dojo.math directly:

n = dojo.math.round(parseFloat(val,10),2);

so it needs to do a dojo.require("dojo.math"). That line is missing. Right?

comment:4 Changed 13 years ago by Tom Trenka

Cc: ttrenka@… added

You're right, the line needs to be there. Why it's not I'm not sure, nor am I sure how it got past the tests (since the tests require at least one column that is a number)...

I'll add it back but I'm not sure where I should add it, dojo/trunk?

comment:5 Changed 13 years ago by Tom Trenka

Resolution: fixed
Status: reopenedclosed

(In [7179]) Fixes #2322, merge for #2370, #1841 and preservation of HTML if starting from HTML data source.

Note: See TracTickets for help on using tickets.