dnd error on contentpane loading (0.4.1 regression)

[frax.free@…]

Hi, In the main page of a html document, I defined a 'standard' contentpane : <div dojoType="ContentPane?" id="center_subPanel" executeScripts="true" cacheContent="false" refreshOnShow="true" sizeMin="60" sizeShare="60" style="overflow:auto;padding-bottom:5px;"

In my js library, its content is loaded with the setUrl function :
var center_subPanel = dojo.widget.byId('center_subPanel');
center_subPanel.domNode.style.display = 'block';
dojo.event.connect(center_subPanel , 'onLoad' , 'end_onLoad');
center_subPanel.setUrl(url);

To try the Dnd API implementation, I used the provided dojo's html file 'tests/dnd/test_simple.html.'
Everything works fine with the 0.4.0 release. But with the 0.4.1 release, an error appears when loading the pane content : 'this.dropTargets is null', HtmlDragManager?.js, line 135.

[guest]

Hi, In the main page of a html document, I defined a 'standard' contentpane : <div dojoType="ContentPane?" id="center_subPanel" executeScripts="true" cacheContent="false" refreshOnShow="true" sizeMin="60" sizeShare="60" style="overflow:auto;padding-bottom:5px;" >

In my js library, its content is loaded with the setUrl function : var center_subPanel = dojo.widget.byId('center_subPanel'); center_subPanel.domNode.style.display = 'block'; dojo.event.connect(center_subPanel , 'onLoad' , 'end_onLoad'); center_subPanel.setUrl(url);

To try the Dnd API implementation, I used the provided dojo's html file 'tests/dnd/test_simple.html.' So we have : center_subPanel.setUrl('tests/dnd/test_simple.html'); Everything works fine with the 0.4.0 release. But with the 0.4.1 release, an error appears when loading the pane content : 'this.dropTargets is null', HtmlDragManager??.js, line 135.

[Mignon Belongie]

I think the fix is to insert the following line in src/dnd/HtmlDragManager.js after line 61 (or thereabouts):

dropTargets: [],

[skinner]

(In [7288]) References #2318. I just applied Mignon's suggested fix, which Dylan had approved. Maybe we can close this ticket now, but somebody who knows more about dojo.dnd should decide that.

[skinner]

(In [7289]) (merge from 0.4 branch) References #2318. I just applied Mignon's suggested fix, which Dylan had approved. Maybe we can close this ticket now, but somebody who knows more about dojo.dnd should decide that.

[alex]

Brian, Mignion, thanks for finding this!

[(none)]

Milestone 0.4.2 deleted