Opened 13 years ago

Closed 13 years ago

#2313 closed defect (fixed)

Dojo ComboBox Widget Destruction Issue

Reported by: sjs@… Owned by: haysmark
Priority: high Milestone:
Component: Widgets Version: 0.4.1
Keywords: Cc:
Blocked By: Blocking:

Description

ComboBox? does not destroy itself properly, leading to a JavaScript? error. Could it have something to do with not disconnecting events?

Attachments (1)

test_ComboBox_destroy.html​ (1.8 KB) - added by sjs@… 13 years ago.
test case

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by sjs@…

Attachment: test_ComboBox_destroy.html​ added

test case

comment:1 Changed 13 years ago by Douglas Hays

Owner: changed from bill to Douglas Hays

comment:2 Changed 13 years ago by haysmark@…

There were two issues: first, dojo's destroy was not working.

Second, the combobox popup was connected to the destroy event. This is a problem because destroy will already try to destroy the popup recursively, so it would try to destroy the popup twice, creating another error.

Now, when you press the killit button in the test, the combobox disappears with no error.

comment:3 Changed 13 years ago by Douglas Hays

Owner: changed from Douglas Hays to haysmark@…

comment:4 Changed 13 years ago by haysmark

Owner: changed from haysmark@… to haysmark

comment:5 Changed 13 years ago by Douglas Hays

Resolution: → fixed
Status: new → closed

(In [8401]) Fixes #2313, #2562, #2883, #2884 (proxy commit of changes made by haysmark). try/catch blocks removed. New queryIgnoreCase added. labelFunc now takes a dojo.data item instead of a string. hidden input tag removed from autocompleter template.

Note: See TracTickets for help on using tickets.