Opened 14 years ago
Closed 14 years ago
#2311 closed defect (fixed)
[cla] setting background color on dialog breaks if done before showing
Reported by: | Owned by: | bill | |
---|---|---|---|
Priority: | high | Milestone: | 0.9beta |
Component: | Dijit | Version: | 0.4.1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
(Assigning to you again, Bill ;-)
If adding background color setting to tests/widget/test_Dialog_createWidget.html like this:
dlgProg = dojo.widget.createWidget("dojo:Dialog",... dlgProg.setBackgroundColor("white");
Then Dialog.js (6973) from 1/3/07 will break on:
156: this.bg.style.backgroundColor = color.toString();
as bg isn't set, probably due to the new delayed initialization of the widget.
Change History (4)
comment:1 Changed 14 years ago by
Component: | Widgets → Dijit |
---|---|
Milestone: | → 0.9 |
comment:2 Changed 14 years ago by
You do realize that this method isn't setting the background color of the actual dialog, but instead of the "backdrop effect" that dims out everything else on the page while the dialog is popped? If this method should be removed then it must be clear how to address the backdrop's color (and opacity?) through a CSS selector.
Best regards Mike
comment:3 Changed 14 years ago by
Right, so we need a CSS class (dijitDialogBackdrop?) that affects the <div> that's placed under the dialog but above everything else, and covers the whole screen.
comment:4 Changed 14 years ago by
Milestone: | 0.9 → 0.9beta |
---|---|
Resolution: | → fixed |
Status: | new → closed |
This is fixed with the new design, where color (and everything else) is specified in the CSS file.
Hmm, we shouldn't have a setBackgroundColor() method in Dialog at all; it should be controlled by CSS. Passing to Koranteng to affect that change.