Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#2309 closed enhancement (fixed)

[patch] Make cache in ComboBox widget work and fix reference bug

Reported by: wolfram.kriesing@… Owned by: haysmark
Priority: high Milestone:
Component: Widgets Version: 0.4.1
Keywords: Cc:
Blocked By: Blocking:

Description

I am using rev6837.

This tiny patch implements the cache that was a TODO in the ComboBox? widget. The cache is used in the dojo.widget.incrementalComboBoxDataProvider for not needing to retreive the same data from the server multiple times.

Therefore a tiny bug needed to be fixed. dojo.widget.ComboBox?._openResultList() used to iterate over the search results by shifting them out of the array, which reduced the array and since it came from the cache (as a reference) the cache was always empty :-(. Also this way we prevent the need to clone the array, since we simply iterate over it non-destructively.

Attachments (4)

ComboBox_cache.patch (2.8 KB) - added by wolfram.kriesing@… 13 years ago.
ComboBox_cache.2.patch (3.3 KB) - added by wolfram.kriesing@… 13 years ago.
ComboBox_cache-against-rev7668.patch (3.4 KB) - added by wolfram.kriesing@… 13 years ago.
latest rev caused conflicts, resolved them
ComboBox_cache-against-rev7668.2.patch (3.3 KB) - added by wolfram.kriesing@… 13 years ago.
fixed merging error

Download all attachments as: .zip

Change History (10)

Changed 13 years ago by wolfram.kriesing@…

Attachment: ComboBox_cache.patch added

comment:1 Changed 13 years ago by wolfram.kriesing@…

The event onSelected was missing too, so this updated patch adds that too.

Changed 13 years ago by wolfram.kriesing@…

Attachment: ComboBox_cache.2.patch added

comment:2 Changed 13 years ago by Douglas Hays

Owner: changed from bill to Douglas Hays
Summary: [patch] Make cache in ComboBox widget work and fix reference bug[patch] Make cache in ComboBox widget work and fix reference bug

Changed 13 years ago by wolfram.kriesing@…

latest rev caused conflicts, resolved them

Changed 13 years ago by wolfram.kriesing@…

fixed merging error

comment:3 Changed 12 years ago by Douglas Hays

Owner: changed from Douglas Hays to haysmark@…

comment:4 Changed 12 years ago by haysmark

Owner: changed from haysmark@… to haysmark

comment:5 Changed 12 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [8458]) Fixes #2885, #2309. AutoCompleter? now inherits from SerializableTextbox?. DateTextbox? now has a Calendar drop down, but still needs RangeBoundTextbox? min/max code working. Calendar now works under 0.9.

comment:6 Changed 12 years ago by alex

(In [8530]) earlier checkins seem to have completely busted InlineEditBox?. This seems to fix. Refs #2885, #2309

Also, we didn't write the style guide because we were looking for something to do one sunny saturday. Compliance is not optional. Continued variances may result in commit privs being revoked. You have been warned.

Note: See TracTickets for help on using tickets.