Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#2301 closed enhancement (fixed)

Patch to re-work buildscripts/internStrings.js main code into buildUtil.js

Reported by: cameron@… Owned by: James Burke
Priority: high Milestone:
Component: BuildTools Version: 0.4.1
Keywords: Cc:
Blocked By: Blocking:

Description

I use an external tool (a java program) to generate my builds.

I was using an embeded python interpreter to call the python version of regexpMagic.

regexpMagic has now been converted to javascript in internStrings.js

The attached patch moves the functions from internStrings.js into buildUtil.js as members of buildUtil to allow them to be used separate from internStrings.js

Attachments (1)

dojo-0.5-move-internStrings-to-buildUtil.patch (13.3 KB) - added by cameron@… 13 years ago.

Download all attachments as: .zip

Change History (8)

Changed 13 years ago by cameron@…

comment:1 Changed 13 years ago by bill

Component: GeneralBuildTools
Owner: changed from anonymous to James Burke

comment:2 Changed 13 years ago by James Burke

Milestone: 0.5

Thanks for the patch. I was hoping to move all the functions out of the top-level script entry points, but I haven't gotten around to it. I'll be picking this change up in the next couple of weeks. Is that timeframe OK, or would it be better for you if I apply the change sooner than later?

comment:3 Changed 13 years ago by cameron

It doesn't really bother me.

I'm happy to do my builds using my patched version in the mean time.

Thanks,

Cameron

comment:4 Changed 12 years ago by James Burke

Milestone: 0.90.4.2

comment:5 Changed 12 years ago by James Burke

Resolution: fixed
Status: newclosed

(In [7186]) Fixes #2301 and #2404, and references #2366. web built dojo.js now has strings interned, and for regular builds, all widget js files have strings interned now for the intern-strings target. To get those things to work, I moved the internStrings.js functions into buildUtil.js, but I did it slightly differently than the patch in #2301.

comment:6 Changed 12 years ago by James Burke

Resolution: fixed

(In [7187]) (merge from 0.4 branch) Fixes #2301 and #2404, and references #2366. web built dojo.js now has strings interned, and for regular builds, all widget js files have strings interned now for the intern-strings target. To get those things to work, I moved the internStrings.js functions into buildUtil.js, but I did it slightly differently than the patch in #2301.

comment:7 Changed 12 years ago by (none)

Milestone: 0.4.2

Milestone 0.4.2 deleted

Note: See TracTickets for help on using tickets.