Opened 14 years ago
Closed 9 years ago
#2298 closed defect (patchwelcome)
Shrinksafe removes comments containing IE's propietary conditional compilation code
| Reported by: | ShrinkSafe not "safe" on IE conditional compilation | Owned by: | Richard Backhouse |
|---|---|---|---|
| Priority: | high | Milestone: | future |
| Component: | ShrinkSafe | Version: | 0.4.1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description (last modified by )
Internet Explorer has a proprietary mechanism to allow for IE-only JavaScript? statements. These statements are "hidden" inside normal comments so that they are ignored by other browsers.
The ShrinkSafe? JavaScript? compressor removes these "comments", thus breaking the IE specific code. It would be nice if it could detect these special comments and leave them intact.
Related links: http://www.javascriptkit.com/javatutors/conditionalcompile.shtml http://fforw.de/post/Dojo_Javascript_Compression_and_IE_conditional_compilation/
Change History (6)
comment:1 Changed 13 years ago by
| Component: | BuildTools → ShrinkSafe |
|---|---|
| Keywords: | shrinksafe compression removed |
comment:2 Changed 13 years ago by
| Milestone: | → 1.1 |
|---|
comment:3 Changed 12 years ago by
| Milestone: | 1.1 → 1.2 |
|---|
comment:4 Changed 12 years ago by
| Description: | modified (diff) |
|---|---|
| Milestone: | 1.2 → future |
moving shrinksafe bugs to future... help wanted.
comment:5 Changed 11 years ago by
| Owner: | changed from alex to Richard Backhouse |
|---|
comment:6 Changed 9 years ago by
| Resolution: | → patchwelcome |
|---|---|
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
moving shrinksafe bugs to 1.2