Opened 11 years ago

Closed 6 years ago

#2298 closed defect (patchwelcome)

Shrinksafe removes comments containing IE's propietary conditional compilation code

Reported by: ShrinkSafe not "safe" on IE conditional compilation Owned by: rbackhouse
Priority: high Milestone: future
Component: ShrinkSafe Version: 0.4.1
Keywords: Cc:
Blocked by: Blocking:

Description (last modified by dylan)

Internet Explorer has a proprietary mechanism to allow for IE-only JavaScript statements. These statements are "hidden" inside normal comments so that they are ignored by other browsers.

The ShrinkSafe JavaScript compressor removes these "comments", thus breaking the IE specific code. It would be nice if it could detect these special comments and leave them intact.

Related links: ​http://www.javascriptkit.com/javatutors/conditionalcompile.shtml ​http://fforw.de/post/Dojo_Javascript_Compression_and_IE_conditional_compilation/

Change History (6)

comment:1 Changed 10 years ago by peller

  • Component changed from BuildTools to ShrinkSafe
  • Keywords shrinksafe compression removed

comment:2 Changed 10 years ago by alex

  • Milestone set to 1.1

comment:3 Changed 10 years ago by dylan

  • Milestone changed from 1.1 to 1.2

moving shrinksafe bugs to 1.2

comment:4 Changed 9 years ago by dylan

  • Description modified (diff)
  • Milestone changed from 1.2 to future

moving shrinksafe bugs to future... help wanted.

comment:5 Changed 8 years ago by peller

  • Owner changed from alex to rbackhouse

comment:6 Changed 6 years ago by neonstalwart

  • Resolution set to patchwelcome
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.