Opened 11 years ago

Closed 6 years ago

#2298 closed defect (patchwelcome)

Shrinksafe removes comments containing IE's propietary conditional compilation code

Reported by: ShrinkSafe not "safe" on IE conditional compilation Owned by: Richard Backhouse
Priority: high Milestone: future
Component: ShrinkSafe Version: 0.4.1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by dylan)

Internet Explorer has a proprietary mechanism to allow for IE-only JavaScript? statements. These statements are "hidden" inside normal comments so that they are ignored by other browsers.

The ShrinkSafe? JavaScript? compressor removes these "comments", thus breaking the IE specific code. It would be nice if it could detect these special comments and leave them intact.

Related links:

Change History (6)

comment:1 Changed 10 years ago by Adam Peller

Component: BuildToolsShrinkSafe
Keywords: shrinksafe compression removed

comment:2 Changed 10 years ago by alex

Milestone: 1.1

comment:3 Changed 10 years ago by dylan

Milestone: 1.11.2

moving shrinksafe bugs to 1.2

comment:4 Changed 10 years ago by dylan

Description: modified (diff)
Milestone: 1.2future

moving shrinksafe bugs to future... help wanted.

comment:5 Changed 8 years ago by Adam Peller

Owner: changed from alex to Richard Backhouse

comment:6 Changed 6 years ago by ben hockey

Resolution: patchwelcome
Status: newclosed
Note: See TracTickets for help on using tickets.