Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#227 closed defect (fixed)

kitchen_sink profile broken because of forEach

Reported by: jkuhnert@… Owned by: anonymous
Priority: high Milestone:
Component: BuildTools Version: 0.2
Keywords: Cc:
Blocked By: Blocking:

Description

It looks like the use of dojo.lang.forEach in the dojo.dnd.HtmlDragManager?'s onMouseMove method "if(!tn){ continue; }" is making rhino unhappy during compression. Maybe the latest rhino (rc2) allows for some command-line ignoring of errors or something similar?

Here is what the contents of dojo.js look like after running "ant -Ddocless=true -Dprofile=kitchen_sink release":

/* Copyright (c) 2004-2005 The Dojo Foundation, Licensed under the Academic Free License version 2.1 or above ** This is a compiled version of Dojo, designed for deployment and not for development. If would like to modify or work with Dojo, please visit http://dojotoolkit.org for more information and to get the 'source' version of this file. */js: "../release/dojo/source.package.js", line 8637: continue must be inside loop js: if(!tn){ continue; } js: ..................... js: "../release/dojo/source.package.js", line 1: Compilation produced 1 syntax errors. js: "../release/dojo/source.package.js", line 8637: continue must be inside loop js: if(!tn){ continue; } js: ..................... js: "../release/dojo/source.package.js", line 1: Compilation produced 1 syntax errors. null

Change History (4)

comment:1 Changed 14 years ago by jkuhnert@…

This actually seems to be happening in mozilla FF 1.5 now as well. "Invalid continue" on the same block.

comment:2 Changed 14 years ago by martinc

I believe that line (HtmlDragManager?.js line 216) should be:

if(!tn){ return "continue"; }

to allow forEach to continue processing the list of drop targets.

comment:3 Changed 14 years ago by alex

Resolution: fixed
Status: newclosed

(In [2307]) using "return;" instead of "continue;". Fixes #227

comment:4 Changed 13 years ago by (none)

Milestone: 0.2release

Milestone 0.2release deleted

Note: See TracTickets for help on using tickets.