#2247 closed defect (fixed)
xdomain builds: Get RichText to work with xdomain builds
| Reported by: | James Burke | Owned by: | James Burke |
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | Loader | Version: | 0.4.1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
Right now src/widget/RichText.js uses document.write to write in a textarea to save info on rich text instances. However, in xdomain builds, this breaks since that document.write code will be called after we have a document ready (but before all the dojo modules have been defined), and this blows away the document.
Attachments (2)
Change History (10)
Changed 13 years ago by
| Attachment: | 2247.patch added |
|---|
comment:1 Changed 13 years ago by
Changed 13 years ago by
| Attachment: | 2247.2.patch added |
|---|
comment:2 Changed 13 years ago by
Attached a new version of the patch. Apparently, the saving for back/forward will only work if the textarea is there when the document is first available, so the document.write call is necessary. So this new patch only allows the save option if Rich Text is not in an xd loading situation, or if it is an xd load, the developer can still enable saving by setting a djConfig.allowXdRichTextSave flag. This will only work if RichText? is part of the dojo.js file.
comment:3 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:4 Changed 13 years ago by
| Resolution: | → fixed |
|---|
(In [6964]) Merged revisions 6938-6963 via svnmerge from svn+ssh://alex@svn.dojotoolkit.org/var/src/dojo/trunk
........
r6939 | bill | 2006-12-29 14:29:40 -0800 (Fri, 29 Dec 2006) | 2 lines
Benchmark for creating a bunch of tooltips; Tests the parser and widget creation speed.
........
r6940 | dylan | 2006-12-29 14:35:42 -0800 (Fri, 29 Dec 2006) | 1 line
fixes #2119, invalid scope in DnD code for cloned tables
........
r6942 | peller | 2006-12-29 15:07:08 -0800 (Fri, 29 Dec 2006) | 1 line
strip out provisional/draft calendar entries from cldr (Wei Huang/IBM, CCLA)
........
r6943 | peller | 2006-12-29 15:07:43 -0800 (Fri, 29 Dec 2006) | 1 line
add task names for better logging context, make quiet builds less noisy
........
r6946 | peller | 2006-12-29 15:17:41 -0800 (Fri, 29 Dec 2006) | 1 line
workaround for saxon on alternate JVMs
........
r6949 | bill | 2006-12-30 00:26:34 -0800 (Sat, 30 Dec 2006) | 7 lines
Improve page load time be defering rendering of hidden sections (currently affects and tooltips and dialogs, but will next do hidden tab panes / accordion panels)
ContentPane?: main changes are here; I set isContainer:false, and then manually parse for subwidgets on first display.
Tooltip: removed template since we can use the original DOM node.
Dialog: defered some code execution until dialog is first shown, including fixing a bug where href was downloaded on page load rather than at Dialog display time.
........
r6950 | bill | 2006-12-30 02:37:41 -0800 (Sat, 30 Dec 2006) | 1 line
defer rendering of deselected tabs until they are selected
........
r6951 | bill | 2006-12-30 04:05:56 -0800 (Sat, 30 Dec 2006) | 1 line
fix memory leak from previous checkin
........
r6952 | jburke | 2006-12-30 07:49:04 -0800 (Sat, 30 Dec 2006) | 1 line
........
r6956 | alex | 2006-12-30 13:43:33 -0800 (Sat, 30 Dec 2006) | 2 lines
bloat
........
r6959 | alex | 2006-12-30 15:01:34 -0800 (Sat, 30 Dec 2006) | 4 lines
the style guide is NOT a fucking "suggestion"
NO CONDITIONALS WITHOUT CURLY BRACES.
........
r6963 | alex | 2006-12-30 22:10:51 -0800 (Sat, 30 Dec 2006) | 2 lines
let the profile specify the loader to use
........
comment:5 Changed 13 years ago by
| Resolution: | → fixed |
|---|
(In [6979]) Merged revisions 6946-6978 via svnmerge from svn+ssh://alex@svn.dojotoolkit.org/var/src/dojo/trunk
........
r6946 | peller | 2006-12-29 15:17:41 -0800 (Fri, 29 Dec 2006) | 1 line
workaround for saxon on alternate JVMs
........
r6949 | bill | 2006-12-30 00:26:34 -0800 (Sat, 30 Dec 2006) | 7 lines
Improve page load time be defering rendering of hidden sections (currently affects and tooltips and dialogs, but will next do hidden tab panes / accordion panels)
ContentPane?: main changes are here; I set isContainer:false, and then manually parse for subwidgets on first display.
Tooltip: removed template since we can use the original DOM node.
Dialog: defered some code execution until dialog is first shown, including fixing a bug where href was downloaded on page load rather than at Dialog display time.
........
r6950 | bill | 2006-12-30 02:37:41 -0800 (Sat, 30 Dec 2006) | 1 line
defer rendering of deselected tabs until they are selected
........
r6951 | bill | 2006-12-30 04:05:56 -0800 (Sat, 30 Dec 2006) | 1 line
fix memory leak from previous checkin
........
r6952 | jburke | 2006-12-30 07:49:04 -0800 (Sat, 30 Dec 2006) | 1 line
........
r6956 | alex | 2006-12-30 13:43:33 -0800 (Sat, 30 Dec 2006) | 2 lines
bloat
........
r6959 | alex | 2006-12-30 15:01:34 -0800 (Sat, 30 Dec 2006) | 4 lines
the style guide is NOT a fucking "suggestion"
NO CONDITIONALS WITHOUT CURLY BRACES.
........
r6963 | alex | 2006-12-30 22:10:51 -0800 (Sat, 30 Dec 2006) | 2 lines
let the profile specify the loader to use
........
r6967 | jburke | 2007-01-02 16:41:06 -0800 (Tue, 02 Jan 2007) | 1 line
Build will fail if the build path before dojo contains a module prefix dir (like if it has src in it)
........
r6968 | bill | 2007-01-02 16:58:20 -0800 (Tue, 02 Jan 2007) | 1 line
fix display of drop down items
........
r6969 | bill | 2007-01-02 17:34:04 -0800 (Tue, 02 Jan 2007) | 1 line
fix check for undefined
........
r6970 | bill | 2007-01-02 17:57:10 -0800 (Tue, 02 Jan 2007) | 3 lines
Rework hiearchy so Menu2Bar isn't a PopupContainer? (since it doesn't popup). Fixes problem that after previous changes, Menu2Bar was being initialized as display:none.
........
r6971 | skinner | 2007-01-02 19:54:58 -0800 (Tue, 02 Jan 2007) | 1 line
more dojo.data work -- a new dojo.data.DeliciousStore? that Mignon ported from dojo.data.old, and several new unit tests
........
r6972 | skinner | 2007-01-02 20:01:59 -0800 (Tue, 02 Jan 2007) | 1 line
deleted the entire src/data/old and tests/data/old directories -- old experimental dojo.data code from early 2006, now obsolete
........
r6973 | jburke | 2007-01-02 21:44:06 -0800 (Tue, 02 Jan 2007) | 1 line
Fixes #2197: using dojo.uri.moduleUri instead of dojo.uri.dojoUri to enable xdomain image loading, and to fit better with the module URI concept.
........
r6974 | jburke | 2007-01-02 22:18:37 -0800 (Tue, 02 Jan 2007) | 1 line
Removing docs and website tasks since they are no longer useful. No more -Ddocless=true now for builds.
........
r6975 | jburke | 2007-01-02 22:20:30 -0800 (Tue, 02 Jan 2007) | 1 line
Missed a comment update
........
r6976 | bill | 2007-01-03 18:27:51 -0800 (Wed, 03 Jan 2007) | 2 lines
Fixes #2268 (dojo.provide and dojo.require calls were messed, confusing package name with widget name)
........
r6977 | bill | 2007-01-03 19:39:25 -0800 (Wed, 03 Jan 2007) | 3 lines
Fixes #2275: programatically created ContentPane?'s are <span> objects, so they need certain CSS applied or the text is overflow:auto, which doesn't work well when ContentPane? is a child of SplitContainer?, etc.
........
Added a patch. Need to get a review since I'm not sure it meets RichText?'s needs. It works fine though for xdomain builds.