Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#2217 closed defect (fixed)

DropdownButton menu non-functional

Reported by: dojo@… Owned by: Douglas Hays
Priority: high Milestone:
Component: Widgets Version: 0.4.1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Clicking on the menu item fails to activate the alert (or onClick event).

The strange thing is that the bug code is basically identical to the test code in tests/widget/test_Button.html which functions just fine.

The code still works fine in 0.3.1 for all browsers.

Attachments (2)

3828.2.html (690 bytes) - added by bill 13 years ago.
2217.patch (1.5 KB) - added by Douglas Hays 13 years ago.

Download all attachments as: .zip

Change History (10)

Changed 13 years ago by bill

Attachment: 3828.2.html added

comment:1 Changed 13 years ago by bill

Description: modified (diff)
Milestone: 0.5

Ah, you should attach testcases to the bug; that's standard procedure. You probably didn't know you can do that because you can't attach until after you've already filed the bug. It's confusing.

Here's the issue:

  1. user clicks combobutton to open menu
  2. user clicks menu item
  3. button loses focus, causing button.onBlur event
  4. button.onBlur() closes menu
  5. menu item never gets onClick event

Button.onBlur() needs to check if the blur event occured within the menu.

comment:2 Changed 13 years ago by bill

Owner: changed from bill to Douglas Hays

Passing to Doug since he's modifying Button right now. The best thing I can think of is to put a timeout in Button.onBlur(), to delay closing the menu. That leaves open the issue of, when the menu closes, where is the focus? Should it go back to the button?

comment:3 Changed 13 years ago by dojo@…

Thanks for the clarification. I will attach testcases in future.

comment:4 Changed 13 years ago by bill

Becky says that using toggle="wipe" on the menu will work around the problem.

comment:5 Changed 13 years ago by dojo@…

Thank-you to you & Becky. It did the trick.

As it turns out, it was the one toggle animation I didn't try.

comment:6 Changed 13 years ago by Douglas Hays

Milestone: 0.90.4.2

Changed 13 years ago by Douglas Hays

Attachment: 2217.patch added

comment:7 Changed 13 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [7084]) Fixes #2217. Already fixed in the trunk.

comment:8 Changed 12 years ago by (none)

Milestone: 0.4.2

Milestone 0.4.2 deleted

Note: See TracTickets for help on using tickets.