Opened 13 years ago

Closed 4 years ago

#2207 closed enhancement (patchwelcome)

[patch][cla] Tree: support editable nodes

Reported by: ornus Owned by: bill
Priority: low Milestone: 1.13
Component: Dijit Version: 0.4.1
Keywords: tree selector Cc: sol@…, Adam Peller
Blocked By: Blocking:

Description (last modified by bill)

current tree selector fires events only on 1st click and on double click. I need a 2nd click event to support following scenario:

  • 1st click - select node
  • double click - expand/collapse node
  • 2nd click - start node rename

this is a standard behavior exhibited by most of the tree controls

Attachments (2)

EditableTree.patch (6.7 KB) - added by bill 8 years ago.
prototype of new EditableTree? widget
EditableTree1_8.patch (6.4 KB) - added by bill 7 years ago.
updated patch to work against 1.8

Download all attachments as: .zip

Change History (20)

comment:1 Changed 12 years ago by bill

Component: WidgetsDojox
Description: modified (diff)
Milestone: 0.9

Hmm, node editing not supported in Dijit tree, so moving to Dojox.

comment:2 Changed 11 years ago by bill

Milestone: 1.3
Owner: changed from bill to Dustin Machi
Summary: need 2nd click event on tree selectorTree: support editable nodes

Was talking to Dylan; he said I could assign this to Dustin or Eugene. Anyway setting it that way for now. After #5719 is fixed maybe this is feasible.

comment:3 Changed 11 years ago by Dustin Machi

Test Comment for batch edit

comment:4 Changed 11 years ago by bill

Description: modified (diff)
Milestone: 1.3future

comment:5 Changed 8 years ago by bill

Component: DojoxDijit
Milestone: future1.8
Owner: changed from Dustin Machi to bill
Status: newassigned

I'll take this, assuming Dustin already have a patch. I'm attaching a prototype.

Changed 8 years ago by bill

Attachment: EditableTree.patch added

prototype of new EditableTree? widget

comment:6 Changed 8 years ago by bill

PS: I meant to type: assuming Dustin *doesn't* already have a patch.

comment:7 Changed 8 years ago by Adam Peller

Cc: Adam Peller added

comment:8 Changed 7 years ago by bill

Milestone: 1.82.0

comment:9 Changed 7 years ago by freeneutron

I'm testing this patch with dojo-release-1.8.1-src. But why labelWidget not respond when I press the character keys in it focus?

comment:10 Changed 7 years ago by bill

Because InlineEditBox has changed since I wrote that prototype; I'll attach a new patch.

Changed 7 years ago by bill

Attachment: EditableTree1_8.patch added

updated patch to work against 1.8

comment:11 Changed 7 years ago by bill

Priority: highlow

comment:12 Changed 6 years ago by dylan

Summary: Tree: support editable nodes[patch][cla] Tree: support editable nodes

Any reason to not put this in 1.9, given that it has a patch/cla?

comment:13 Changed 6 years ago by bill

The patch is more of a proof of concept, not something I want to check into dijit as-is. I probably wouldn't want to really create an InlineEditBox for every TreeNode, and not sure I would want a separate Tree subclass, as opposed to a flag, just to support TreeNode editing.

comment:14 Changed 6 years ago by bill

Milestone: 2.01.10

Might as well check this into SVN and then merge to github, so it's available for the 1.x and 2.x streams.

comment:15 Changed 5 years ago by bill

Milestone: 1.101.11

comment:16 Changed 4 years ago by bill

Milestone: 1.11future

comment:17 Changed 4 years ago by dylan

Milestone: future1.12

Is there still interest in moving this from a proof of concept to something that's production quality? Obviously would need a major modernizing update.

comment:18 Changed 4 years ago by bill

Resolution: patchwelcome
Status: assignedclosed

I won't have time to do that. Also not sure it's worth it anymore, since the Tree is very desktop-centric and most modern web-apps are geared towards mobile.

Note: See TracTickets for help on using tickets.