Opened 14 years ago
Closed 5 years ago
#2207 closed enhancement (patchwelcome)
[patch][cla] Tree: support editable nodes
| Reported by: | ornus | Owned by: | bill |
|---|---|---|---|
| Priority: | low | Milestone: | 1.13 |
| Component: | Dijit | Version: | 0.4.1 |
| Keywords: | tree selector | Cc: | [email protected]…, Adam Peller |
| Blocked By: | Blocking: |
Description (last modified by )
current tree selector fires events only on 1st click and on double click. I need a 2nd click event to support following scenario:
- 1st click - select node
- double click - expand/collapse node
- 2nd click - start node rename
this is a standard behavior exhibited by most of the tree controls
Attachments (2)
Change History (20)
comment:1 Changed 13 years ago by
| Component: | Widgets → Dojox |
|---|---|
| Description: | modified (diff) |
| Milestone: | 0.9 |
comment:2 Changed 13 years ago by
| Milestone: | → 1.3 |
|---|---|
| Owner: | changed from bill to Dustin Machi |
| Summary: | need 2nd click event on tree selector → Tree: support editable nodes |
Was talking to Dylan; he said I could assign this to Dustin or Eugene. Anyway setting it that way for now. After #5719 is fixed maybe this is feasible.
comment:4 Changed 12 years ago by
| Description: | modified (diff) |
|---|---|
| Milestone: | 1.3 → future |
comment:5 Changed 9 years ago by
| Component: | Dojox → Dijit |
|---|---|
| Milestone: | future → 1.8 |
| Owner: | changed from Dustin Machi to bill |
| Status: | new → assigned |
I'll take this, assuming Dustin already have a patch. I'm attaching a prototype.
comment:6 Changed 9 years ago by
PS: I meant to type: assuming Dustin *doesn't* already have a patch.
comment:7 Changed 9 years ago by
| Cc: | Adam Peller added |
|---|
comment:8 Changed 8 years ago by
| Milestone: | 1.8 → 2.0 |
|---|
comment:9 Changed 8 years ago by
I'm testing this patch with dojo-release-1.8.1-src. But why labelWidget not respond when I press the character keys in it focus?
comment:10 Changed 8 years ago by
Because InlineEditBox has changed since I wrote that prototype; I'll attach a new patch.
comment:11 Changed 8 years ago by
| Priority: | high → low |
|---|
comment:12 Changed 8 years ago by
| Summary: | Tree: support editable nodes → [patch][cla] Tree: support editable nodes |
|---|
Any reason to not put this in 1.9, given that it has a patch/cla?
comment:13 Changed 8 years ago by
The patch is more of a proof of concept, not something I want to check into dijit as-is. I probably wouldn't want to really create an InlineEditBox for every TreeNode, and not sure I would want a separate Tree subclass, as opposed to a flag, just to support TreeNode editing.
comment:14 Changed 7 years ago by
| Milestone: | 2.0 → 1.10 |
|---|
Might as well check this into SVN and then merge to github, so it's available for the 1.x and 2.x streams.
comment:15 Changed 6 years ago by
| Milestone: | 1.10 → 1.11 |
|---|
comment:16 Changed 5 years ago by
| Milestone: | 1.11 → future |
|---|
comment:17 Changed 5 years ago by
| Milestone: | future → 1.12 |
|---|
Is there still interest in moving this from a proof of concept to something that's production quality? Obviously would need a major modernizing update.
comment:18 Changed 5 years ago by
| Resolution: | → patchwelcome |
|---|---|
| Status: | assigned → closed |
I won't have time to do that. Also not sure it's worth it anymore, since the Tree is very desktop-centric and most modern web-apps are geared towards mobile.
Hmm, node editing not supported in Dijit tree, so moving to Dojox.