Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#2198 closed defect (fixed)

dojo.flash DojoExternalInterface flash6 -> javascript communication severely broken

Reported by: dojo@… Owned by: bradneuberg
Priority: high Milestone: 1.1
Component: Storage/Flash Version: 0.4.1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bradneuberg)

The following code doesn't function as expected:

DojoExternalInterface.call('alert', null, 'a');
DojoExternalInterface.call('alert', null, 'b');
DojoExternalInterface.call('alert', null, 'c');

Instead of three alert dialogs that say 'a', 'b' and then 'c', three alert dialogs that all say 'c' popup.

Attachments (2)

dojo.flash.patch (3.1 KB) - added by dojo@… 13 years ago.
dojo.flash.test.patch (1.1 KB) - added by dojo@… 13 years ago.
test case

Download all attachments as: .zip

Change History (14)

Changed 13 years ago by dojo@…

Attachment: dojo.flash.patch added

comment:1 Changed 13 years ago by bradneuberg

Can you give me a full test case with that code? It might be something in the surrounding code.

comment:2 Changed 13 years ago by bradneuberg

When I start putting together my 0.5 bugs I will incorporate this patch and make sure it doesn't break Dojo Storage's use of Dojo Flash; thanks for the submission. I also would like a simplified test case to make sure it fixes things.

comment:3 Changed 13 years ago by bradneuberg

Milestone: 0.5

Changed 13 years ago by dojo@…

Attachment: dojo.flash.test.patch added

test case

comment:4 Changed 13 years ago by Aman Gupta <dojo@…>

Is the test case satisfactory or should I do something more extensive?

comment:5 Changed 13 years ago by Aman Gupta <dojo@…>

Forgot to properly set the return result variable in my patch, flash.js should use the following code:

// return the results to flash
plugin.SetVariable("_" + invokeID + "_returnResult", results);

comment:6 Changed 13 years ago by bradneuberg

Hi; please tell me more about the browser, browser version, and platform you experienced this on. Did it happen all the browsers you tried, or on a specific one? I imagine it was IE....

comment:7 Changed 13 years ago by bradneuberg

severity: criticalmajor

Downgrading from critical to major, since nothing in Dojo Storage depends on this functionality, and Dojo Flash mostly exists to serve Dojo Storage's needs at this point.

comment:8 Changed 12 years ago by dylan

Milestone: 0.91.0

comment:9 Changed 12 years ago by bradneuberg

Milestone: 1.01.1

comment:10 Changed 12 years ago by bradneuberg

Milestone: 1.11.2

I'm completely refactoring Dojo Flash to work with Dojo 1.0's architecture; I'll retest this bug once I do so.

comment:11 Changed 12 years ago by bradneuberg

Description: modified (diff)
Resolution: fixed
Status: newclosed

I thought I closed this bug; Dojo Storage was refactored extensively for 1.1. Marking as FIXED.

comment:12 Changed 12 years ago by bill

Milestone: 1.21.1
Note: See TracTickets for help on using tickets.