Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#2143 closed defect (wontfix)

Dialog can not be placed when scroll in FireFox

Reported by: panhao_pkuss@… Owned by: koranteng
Priority: high Milestone: 0.9
Component: Widgets Version: 0.4.1
Keywords: Dialog Cc:
Blocked By: Blocking:

Description

In FireFox?, when I show a Dialog widget, and then I scroll the window, the place of the Dialog will not be in the center of the screen. But it work well in IE. The "test_Dialog.html" demo alse has this problem.

I modify the Dialog.js file. If I change dojo.event.connect(document.documentElement, "onkey", this, "_onKey"); to dojo.event.connect(document, "onkey", this, "_onKey"); and its disconnect function, it work well in both FF and IE, and do not affect the "onkey" event.

I think this is a defect, and please fix it in next version.

Thanks.

Change History (5)

comment:1 Changed 13 years ago by dylan

Milestone: 0.9

comment:2 Changed 13 years ago by koranteng

Owner: changed from bill to koranteng

comment:3 Changed 13 years ago by koranteng

This is a bug in Firefox 1.0 and 1.5. The underlying issue is that the window.onscroll event is not fired reliably in those versions. The suggested fix would deal with key presses (page up/page down) but not with mouse clicks or dragging of the scrollbar.

Note: it has since been fixed in Firefox 2.0.

comment:4 Changed 13 years ago by bill

Resolution: wontfix
Status: newclosed

Ah if this is working in FF 2 then I don't want to bother fixing it. FF1.5 is end-of-life pretty soon anyway, I think in April.

comment:5 Changed 13 years ago by koranteng

A note for future reference.

A fix would involve checking for Gecko 1.8 and below and additionally connecting to the onscroll event on the document.documentElement which seems to be fired more reliably. You'd have to connect to both the window and documentElement to get reliable notifications (so sometimes you'd be processing twice the number of events)

Note: See TracTickets for help on using tickets.