Opened 13 years ago

Closed 13 years ago

#2088 closed defect (fixed)

Modal Dialog does not scroll on overflow

Reported by: kyle@… Owned by: koranteng
Priority: high Milestone: 0.9
Component: Widgets Version: 0.4
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

When using a modal dialog and having content loaded via AJAX, the dialog does not scroll on overflow. It will expand beyond the visible screen. The dialog adheres to the max-height and max-width properties but the content continues beyond the border of the dialog height. Screenshots can be provided.

CSS:

.dojoDialog {
	background : #eee;
	border : 1px solid #999;
	-moz-border-radius : 5px;
	padding : 4px;
	width: 50%;
	max-width: 75%;
	max-height: 500px;
	overflow:scroll;
}

JS:

function showme(paneid)
{
	gethelp(paneid); //gets the help information and loads it into the span tag innerHTML of the dialog
	dlg.show(); //shows the dialog
}

Change History (4)

comment:1 Changed 13 years ago by bill

Description: modified (diff)

There is no widget called "Modal Dialog" but I guess you are talking about Dialog. (Or are you talking about ModalFloatingPane??) This is related to #757.

In the future please attach testcases (an entire HTML file) rather than just inlining code snippets.

Anyway, Dialog doesn't support having it's size set, AFAIK.

comment:2 Changed 13 years ago by dylan

Milestone: 0.9

comment:3 Changed 13 years ago by koranteng

Owner: changed from bill to koranteng

comment:4 Changed 13 years ago by bill

Resolution: fixed
Status: newclosed

(In [7454]) The dialog's containerNode needs its overflow set to auto - and we need to set the height so that overflow takes effect. We also handle the case of dynamically loaded content and lengthen accordingly. Fixes #757 and #2088.

Patch from Koranteng (IBM, CCLA on file).

Note: See TracTickets for help on using tickets.