Menu inside ContentPane not cleaned up on ContentPane destroy or reload.

[[email protected]…]

Only occurs in IE ( I'm using IE7 ), reproduced with 0.4.1rc2 also.

The attached page has a two content panes, one which has a button to load a new page into the second pane. The page initially loaded by the pane contains a menu widget. After loading another page which does not contain a menu widget, clicking anywhere on the page will result in a "offsetWidth is null or not an object" js error. This only occurs if the new page does not have a menu, loading a new page with a menu works fine.

I also ran into another bug while creating this repro case, in dom.js dojo.dom.destroyNode does node.outerHTML= to prevent a memory leak. In my repro case, node can be undefined. We should insure that node is not undefined before trying to clear the outerHTML.

[[email protected]…]

repro case, place in tests/widget

[bill]

It doesn't seem valid for a ContentPane? to contain a Menu2 w/contextMenuForWindow="true". Can you try a simpler test, where the content pane just has a menu bar, or maybe a menu attached to a certain node?

[[email protected]…]

a more simple test

[[email protected]…]

simple test

[[email protected]…]

simple test

[[email protected]…]

test_Menu2_contentPane.2.html uses two simple pages (attached) as content for the pane, and still reproduces the problem.

[[email protected]…]

not sure if this is the correct fix, but overriding the destroy method in dojo.widget.Menu2 solves the problem:

destroy: function() {

dojo.widget.PopupManager?.closed(this);

},

[bill]

The PopupManager? code has been completely redone for 0.9 so this probably isn't an issue anymore, but need to test.

[bill]

See related bugs #3300 and #4980. This is currently broken because menus are moved to document.body and thus the cleanup doesn't work.

[bill]

Looks like this will be fixed by sfoster's conversion of ContentPane to use dojo.html.