Opened 13 years ago

Closed 12 years ago

#2040 closed defect (fixed)

[patch][cla] ContentPane examines wrong property on nested exceptions

Reported by: mikewse@… Owned by: mumme
Priority: high Milestone: 0.9
Component: Dojox Version: 0.4.1rc1
Keywords: Cc:
Blocked By: Blocking:

Description

In the code below from ContentPane?.js, the caught exception "e" is queried for e.description. This should probably be e.message. Could I also suggest that st[i] is moved to the end of the string, as it will expand into the whole function definition?

_runStack: function(stName){
  var st = this[stName]; var err = "";
  var scope = this.scriptScope || window;
  for(var i = 0;i < st.length; i++){
    try{
      st[i].call(scope);
    }catch(e){ 
      err += "
"+st[i]+" failed: "+e.description;
    }
  }

Best regards Mike Wilson

Change History (5)

comment:1 Changed 13 years ago by bill

Milestone: 0.5
Owner: changed from bill to mumme

comment:2 Changed 13 years ago by bill

Component: WidgetsDojox

comment:3 Changed 12 years ago by mumme

Milestone: 0.91.0
Status: newassigned

Hum, I don't think this code will survive into the dojox ContentPane?, but I leave it open just in case.

comment:4 Changed 12 years ago by mumme

(In [9803]) Initial checkin of a enhanced ContentPane?, with support for scripts, styles, path adjustments, much like in 0.4, but with some enhancements. Removed the java handler code though (nobody requested it). refs #3594, refs#2852, refs #2040, refs #3217, refs #3738

comment:5 Changed 12 years ago by mumme

Milestone: 1.00.9
Resolution: fixed
Status: assignedclosed

This code didn't survive dojox ContentPane? port, but I tried to make use of error.message where appropriate.

Note: See TracTickets for help on using tickets.