Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#2039 closed enhancement (fixed)

test for parseWidgets causes unnecessary exception, disturbs debugging

Reported by: mikewse@… Owned by: bill
Priority: high Milestone:
Component: Parser Version: 0.4.1
Keywords: Cc:
Blocked By: Blocking:

Description

In Parse.js, the following snippet tests if parseWidgets=="false":

try{
  if(node.getAttribute("parseWidgets").toLowerCase() == "false"){
    return {};
  }
}catch(e){/*continue*/}

This causes f ex FireBug? to break when "Break On Errors" is active, as in many cases node.getAttribute() will return null and .toLowerCase() will throw a "null has no properties" exception (which is no problem as the exception is consumed right after). But, it is bit of an annoyance having to "continue" over and over again while debugging your own code in FireBug?. (Assigning to Alex as he checked in this code.)

Best regards Mike Wilson

Change History (5)

comment:1 Changed 13 years ago by bill

Milestone: 0.5
Owner: changed from alex to bill
Status: newassigned

comment:2 Changed 13 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [6767]) Fixes #2039

comment:3 Changed 13 years ago by bill

Resolution: fixed

(In [6768]) Merge [6767] from trunk, which fixes #2068 and #2039.

comment:4 Changed 13 years ago by bill

Milestone: 0.50.4.1

comment:5 Changed 12 years ago by (none)

Milestone: 0.4.1

Milestone 0.4.1 deleted

Note: See TracTickets for help on using tickets.