Opened 13 years ago

Closed 12 years ago

#2022 closed defect (fixed)

[patch][cla] BUFakeNode.removeAttributeNode() broken

Reported by: james@… Owned by: dylan
Priority: high Milestone: 0.9
Component: TestFramework Version: 0.4
Keywords: Cc:
Blocked By: Blocking:

Description

The BUFakeNode.prototype.removeAttributeNode() method at line 299 of testtools/JsFakeDom/BUFakeDom.js is broken. When called it throws an error: '"attributes" is not defined'.

The fix is simple. All instances of "attributes" inside the method should be replaced by "this.attributes".

Attachments (1)

removeAttributeNode.patch (870 bytes) - added by james@… 13 years ago.
Replaces all instances of "attributes" with "this.attributes inside BUFakeNode.prototype.removeAttributeNode()

Download all attachments as: .zip

Change History (3)

Changed 13 years ago by james@…

Attachment: removeAttributeNode.patch added

Replaces all instances of "attributes" with "this.attributes inside BUFakeNode.prototype.removeAttributeNode()

comment:1 Changed 12 years ago by dylan

Milestone: 0.9
Owner: changed from alex to dylan
Status: newassigned
Summary: BUFakeNode.removeAttributeNode() broken[patch][cla] BUFakeNode.removeAttributeNode() broken

comment:2 Changed 12 years ago by dylan

Resolution: fixed
Status: assignedclosed

(In [7149]) fixes #2022, BUFakeNode.removeAttributeNode() broken, thanks James

Note: See TracTickets for help on using tickets.