Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#202 closed enhancement (fixed)

[patch] Allow drag and drop of table rows

Reported by: Sylvain Wallez <sylvain@…> Owned by: alex
Priority: high Milestone:
Component: Core Version: 0.2
Keywords: Cc: sylvain@…
Blocked By: Blocking:

Description

Here's a patch to allow table rows to be drag'n dropped. This requires adding a surrounding <table> and <tbody> to the <tr>, and setting fixed widths to the <td>s to avoid them being packed.

Attachments (2)

table_dnd.diff (3.5 KB) - added by Sylvain Wallez <sylvain@…> 14 years ago.
Patch against r2164
HtmlDragAndDrop.js.patch (1.6 KB) - added by Sylvain Wallez <sylvain@…> 14 years ago.
Updated patch against r3003

Download all attachments as: .zip

Change History (12)

Changed 14 years ago by Sylvain Wallez <sylvain@…>

Attachment: table_dnd.diff added

Patch against r2164

comment:1 Changed 14 years ago by Sylvain Wallez <sylvain@…>

Also tries to fix a memory leak by ensuring dragClone is nulled, but the leak is still there.

comment:2 Changed 14 years ago by alex

Owner: changed from anonymous to alex
Status: newassigned
Version: 0.1

Hi Sylvain,

I'd love to merge this patch, but I don't have a CLA from you. The Dojo CLA is identical to the Apache CLA, and can be found at http://dojotoolkit.org/icla.txt

Regards.

comment:3 Changed 14 years ago by Sylvain Wallez <sylvain@…>

After failing to fax the CLA (don't know what end was broken), I sent it by snail mail around dec 20th. Did you get it?

comment:4 Changed 14 years ago by dylan

Cc: sylvain@… added
Resolution: fixed
Status: assignedclosed

Sorry Sylvain, we're in the middle of moving our office location, and our fax number changed. It has been received.

comment:5 Changed 14 years ago by Sylvain Wallez <sylvain@…>

Milestone: 0.3release
Resolution: fixed
Status: closedreopened
Version: 0.10.2

Marked as closed, but the patch didn't made it in SVN...

Changed 14 years ago by Sylvain Wallez <sylvain@…>

Attachment: HtmlDragAndDrop.js.patch added

Updated patch against r3003

comment:6 Changed 14 years ago by anonymous

Resolution: fixed
Status: reopenedclosed

comment:7 Changed 14 years ago by sami.elhini@…

Resolution: fixed
Status: closedreopened

Hi,

I'm trying to use the table drag and drop and can't get it to work. Having seen this patch, I decided to compare it to the HtmlDragAndDrop?.js in both the 0.3 release and the 5/17/2006 nightly build and there is no code that resembles the patch. Do I need to download from subversion?

comment:8 Changed 14 years ago by dylan

Milestone: 0.3release0.3.1
Status: reopenednew

what happened here... did this patch rot on the vine? was this fixed?

comment:9 Changed 14 years ago by alex

Resolution: fixed
Status: newclosed

merged in [4245]. Marking fixed.

comment:10 Changed 13 years ago by (none)

Milestone: 0.3.1

Milestone 0.3.1 deleted

Note: See TracTickets for help on using tickets.