Changes between Initial Version and Version 1 of Ticket #2009


Ignore:
Timestamp:
Nov 28, 2006, 1:00:22 AM (13 years ago)
Author:
bill
Comment:

I reproduced the bug. The problem w/your fix is that for initially disabled items, when Menu2Item is created, this.parent isn't set. (Especially for programatic creation) Note also that MenuBarItem2 has hardcoded the classnames.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2009 – Description

    initial v1  
    11Disabled context menu's (from a tree context menu in my case - but it does not really matter) won't be grayed out because these items get the class 'undefined':
    22
    3 Menu2.js should read in function setDisabled (currently #526 and #528):
    4 -----------------
     3Menu2.js should read in function setDisabled (currently line 526 and line 528):
     4{{{
    55...
    66dojo.html.addClass(this.domNode, this.parent.disabledClass);
     
    88dojo.html.removeClass(this.domNode, this.parent.disabledClass);
    99...
    10 -----------------
     10}}}
    1111
    12 instead of 
     12instead of
    1313
    14 -----------------
     14{{{
    1515...
    1616dojo.html.addClass(this.domNode, this.disabledClass);
     
    1818dojo.html.removeClass(this.domNode, this.disabledClass);
    1919...
    20 -----------------
     20}}}
    2121
    2222because the class "disabledClass" is defined in PopupMenu2 and not in MenuItem2.