Menu2/MenuItem2 disabled context menu items get class 'undefined'

[guest]

Disabled context menu's (from a tree context menu in my case - but it does not really matter) won't be grayed out because these items get the class 'undefined':

Menu2.js should read in function setDisabled (currently line 526 and line 528):

...
dojo.html.addClass(this.domNode, this.parent.disabledClass);
...
dojo.html.removeClass(this.domNode, this.parent.disabledClass);
...

instead of

...
dojo.html.addClass(this.domNode, this.disabledClass);
...
dojo.html.removeClass(this.domNode, this.disabledClass);
...

because the class "disabledClass" is defined in PopupMenu2 and not in MenuItem2.

Thx!

[bill]

I reproduced the bug. The problem w/your fix is that for initially disabled items, when Menu2Item is created, this.parent isn't set. (Especially for programatic creation) Note also that MenuBarItem2 has hardcoded the classnames.

[bill]

Actually, the problem is pretty severe (initially disabled items are showing up as enabled). Fixing now...

[bill]

(In [6724]) Fixes #2009, and also fixes some API comments.

[(none)]

Milestone 0.4.1 deleted