Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#1990 closed defect (fixed)

Dojo demos appear not to run under IE7

Reported by: joe@… Owned by: Jared Jurkiewicz
Priority: high Milestone:
Component: General Version: 0.4
Keywords: Cc:
Blocked By: Blocking:

Description

Opening demoEngine.html in IE7 does not produce any results.

Steps:

  1. in file explorer right click on demoEnging.html
  2. IE displays a yellow bar at the top of the IE window warning about a security risk
  3. Click and select allow script to run.

exp: demo application appears act: nothing is shown in the browser. The tab title is labeled "Dojo Demos", but no contont or errors are produced

true in dojo 0.4.0 true in dojo 0.4.1rc

dojo 0.3.1 reports an error: "FATAL: symbol 'dojo.widget' is not defined after loading 'package.js'"

comment I'm working on a project, Dojo seems pretty nice under Firefox, but too many of my users have IE to ognore it.

Attachments (4)

dojo_0.4.3_xhr_ie7_force.patch (584 bytes) - added by Jared Jurkiewicz 12 years ago.
Patch that puts in a flag into 0.4.3 to allow forsing of activeX xhr on IE 7
dojo_0.4.3_xhr_ie7_force_alternate.patch (1.1 KB) - added by Jared Jurkiewicz 12 years ago.
Patch that allows forcing of activeX xhr on IE 7, *and* auto-enables if the files are being local-loaded to begin with (file:)
dojo_0.9_xhr_ie7_force.patch (540 bytes) - added by Jared Jurkiewicz 12 years ago.
Patch that puts in an option to force ActiveX xhr on IE 7
dojo_0.9_xhr_ie7_force_alternate.patch (899 bytes) - added by Jared Jurkiewicz 12 years ago.
Patch that puts in an option to force ActiveX xhr on IE 7 and auto-enables on local loads.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 13 years ago by joe@…

This appears to be an issue with opening the file directly in IE7 instead of serving it from a webserver. Deploying Dojo 0.4.1 to tomcat 5.5 results is properly working demos.

comment:2 Changed 13 years ago by alex

Milestone: 0.4.1
Resolution: invalid
Status: newclosed

browser issue. Not our bug. Marking as such and closing.

comment:3 Changed 12 years ago by (none)

Milestone: 0.4.1

Milestone 0.4.1 deleted

comment:4 Changed 12 years ago by Jared Jurkiewicz

Resolution: invalid
Status: closedreopened

Alex,

I'm reopening this as you said you were amenable to the patch suggestion. I had a bit more thought on this last night and think there's even a nicer patch we could do to make this automatic for users when they are on IE 7 and doing local file loads. 'll attach both patches and you can pick which you prefer.

Basically patch files without alternate in the name are the original patch suggestion, allow a djConfig option users can set. Patched with the 'alternate' in the name take it one step further. It does a check that the browser is IE and if the window protocol (how you opened dojo), is file: (local load), then automatically set that flag for you. I've tested this with the demos we have in 0.4.3 and it works nicely. I'll also gen a patch set for 0.9 and append those to this as well.

Changed 12 years ago by Jared Jurkiewicz

Patch that puts in a flag into 0.4.3 to allow forsing of activeX xhr on IE 7

Changed 12 years ago by Jared Jurkiewicz

Patch that allows forcing of activeX xhr on IE 7, *and* auto-enables if the files are being local-loaded to begin with (file:)

Changed 12 years ago by Jared Jurkiewicz

Patch that puts in an option to force ActiveX xhr on IE 7

Changed 12 years ago by Jared Jurkiewicz

Patch that puts in an option to force ActiveX xhr on IE 7 and auto-enables on local loads.

comment:5 Changed 12 years ago by Jared Jurkiewicz

There. I've added the patches. My preference is for the alternate one, as it only engages when it's a local load of dojo and does get local usage of IE 7 working for 0.4.3 and 0.9.

comment:6 Changed 12 years ago by guest

Please note, that tickets #1711, #2975 are due to the same cause. This one would fix them.

Konstantin Kolinko

comment:7 Changed 12 years ago by Adam Peller

Owner: changed from anonymous to Jared Jurkiewicz
Status: reopenednew

comment:8 Changed 12 years ago by Jared Jurkiewicz

(In [9789]) Fixing browser host env to get local file loads working on IE 7 (and providing option to force ActiveX xhr all the time if so desirred.) refs #1990

comment:9 Changed 12 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [9790]) Fixing dojo so that local file loads in IE 7 work. fixes #1990

comment:10 Changed 12 years ago by Jared Jurkiewicz

I applied the alternate patches I noted in this defect. Tested on IE 6, IE 7, for 0.9 and 0.4.X, seems to work fine now.

Note: See TracTickets for help on using tickets.