widgetsInTemplate does not process nested widgets

[[email protected]…]

Sub widgets that are wrapped by, for instance, accordion panes or split panes, aren't processed. So dojoAttachPoint or dojoAttachEvent are ignored for those sub widgets.

I fixed by setting an attribute on nodes (watermark) and then check for the mark. If there is no mark, then its a wrapper widget (or something like that), so lets process its children.

On DomWidget?.js near line 586 I made:

if(subnodes[i].getAttribute('dojoType')){
  subnodes[i].setAttribute('_isSubWidget', true);
}
subnodes[i].setAttribute('_watermark', true);

and near line 618 change to:

if(cwidget.extraArgs['_watermark'] &&
   (cwidget._processedSubWidgets || !cwidget.extraArgs['_issubwidget'])){ continue; }

[bill]

You need to supply a testcase w/javascript file, template file, and test html file.

[promag]

This simple test shows that wrapped sub widgets aren't attached

[alex]

Milestone 2.0 deleted

[bill]

I've got a feeling that we will switch to using the DTL code before addressing this issue.

For now, you just need to workaround by creating widgets like the TabContainer and it's children programatically, and then attaching them under your widget.

[dylan]

There are many solutions, but also some challenges with nested or subwidgets.

I'm going to close this as wontfix, because I think we've gone as far as we can reasonably go with the approach to nesting widgets in the 1.x codebase.

[bill]

This is still something I want to look at, although not for 1.9.

[bill]

Actually, this already works well, and I think it's worked since 1.0. The only failures in the test case, when updated for 1.0, are:

1. The infinite recursion test (test 2): we aren't supposed to support that.
2. The dojoAttachPoint inside the button (in test 3). The way dijit/form/Button::_fillContent() copies the srcNodeRef.innerHTML to this.label isn't compatible with having dojoAttachPoint inside a button.

[bill]

test case updated to run against 1.0 (and 1.9)