Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#195 closed defect (fixed)

Minimal profile build is broken

Reported by: martinc Owned by: alex
Priority: high Milestone:
Component: BuildTools Version: 0.1
Keywords: Cc:
Blocked By: Blocking:

Description

The minimal profile includes only bootstap1.js, bootstrap2.js and hostenv_browser.js, since the 'dependencies' array is empty in minimal.profile.js. However, that last file uses dojo.lang.isArray, so dojo.byIdArray (and dojo.hostenv.byIdArray) do not work in a minimal build. The (trivial) fix would be to change the 'dependencies' array in minimal.profile.js to:

var dependencies = [

"dojo.event.*"

];

Change History (4)

comment:1 Changed 14 years ago by martinc

Doh! Of course, I meant:

var dependencies = [

"dojo.lang.*"

];

comment:2 Changed 14 years ago by alex

Milestone: → 0.2release
Owner: changed from anonymous to alex
Status: new → assigned

comment:3 Changed 14 years ago by alex

Resolution: → fixed
Status: assigned → closed

(In [2179]) fixing byIdArray. Previously it referenced dojo.lang, which may not be available. fixes #195

NOTE TO COMMITTERS: bootstrap*.js and hostenv_*.js files should have NO external dependencies. Please code accordingly.

comment:4 Changed 12 years ago by (none)

Milestone: 0.2release

Milestone 0.2release deleted

Note: See TracTickets for help on using tickets.