Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#1949 closed defect (fixed)

Flicker in dojo.lfx.wipeIn with Firefox 2.0

Reported by: ryan AT hyperstep DOT com Owned by: bill
Priority: high Milestone:
Component: HTML Version: 0.4
Keywords: Cc:
Blocked By: Blocking:

Description

If you check out http://archive.dojotoolkit.org/nightly/tests/lfx/test_wipes2.html in Firefox 2.0, you will see a severe screen flicker on wipeIn. It's bad enough that it makes wipeIn pretty much useless.

I'm not sure how different the lfx approach is to the old fx approach in terms of getting the start and target height, but I know the fx code did not have this problem (and worked fine with fixed size elements), so you might want to refer to that.

Change History (4)

comment:1 Changed 13 years ago by bill

Milestone: 0.4.1
Owner: changed from Bryan Forbes to bill
Status: newassigned

Ah, it's from the code:

// get node height, either it's natural height or it's height specified via style or class attributes
// (for FF, the node has to be (temporarily) rendered to measure height)
dojo.html.show(node);
var height = dojo.html.getBorderBox(node).height;
dojo.html.hide(node);

I'll take a look. I guess we need to render it off screen.

comment:2 Changed 13 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [6661]) Fixes #1949

comment:3 Changed 13 years ago by ryan AT hyperstep DOT com

Thanks bill, seems to work fine now.

comment:4 Changed 12 years ago by (none)

Milestone: 0.4.1

Milestone 0.4.1 deleted

Note: See TracTickets for help on using tickets.