Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#1900 closed enhancement (fixed)

[patch] [cla] ResizeHandle.js - Added virtual resizing option

Reported by: Jonathan Bond-Caron Owned by: dante
Priority: high Milestone: 0.9
Component: Dojox Version: 0.4
Keywords: Cc:
Blocked By: Blocking:

Description

Very minor changes,

activeResize: false -- allows styling of the new window size as the mouse is moved

(instead of changing the domnode directly)

minHeight: 100, minWidth: 100, Provide some default resize constraints

Attachments (1)

resize.patch (4.7 KB) - added by Jonathan Bond-Caron 13 years ago.
Small enhancements

Download all attachments as: .zip

Change History (9)

Changed 13 years ago by Jonathan Bond-Caron

Attachment: resize.patch added

Small enhancements

comment:1 Changed 13 years ago by bill

This is kind of a big patch. Have you filed a CLA? I don't see you on file. (www.dojotoolkit.org/icla.txt)

Also, I don't really understand the bug description. Does setting activeResize=false do something like a wire frame, so that the widget's size doesn't actually change until you mouse-up?

comment:2 Changed 13 years ago by Jonathan Bond-Caron

Ya I've faxed an CLA, it should be there as Jonathan Bond-Caron.

The widget's size doesn't actually change until you mouse-up... It adds a div to the target node and resizes that until there's a mouse up.

Note that there's a slight problem with IE, the background is not transparent...

.dojoHtmlResizeHandleClone {

border: 1px dashed #666666; background-color: transparent;

}

Still would not fix it for me. I looked into it some more and it looks like all iframes in dojo could use the allowtransparency="true".

j

comment:3 Changed 13 years ago by bill

Milestone: 0.5
Summary: ResizeHandle.js - Added virtual resizing option[patch] [cla?] ResizeHandle.js - Added virtual resizing option

OK, I'll ask about the CLA (you aren't listed on http://dojo.jot.com/WikiHome/ContributorListing). Thanks for the patch.

comment:4 Changed 13 years ago by bill

Summary: [patch] [cla?] ResizeHandle.js - Added virtual resizing option[patch] [cla] ResizeHandle.js - Added virtual resizing option

OK, Carrie has your CLA. I'll process the patch ASAP.

comment:5 Changed 12 years ago by bill

Component: WidgetsDojox

We've gotten rid of ResizeHandle? altogether in Dijit, moving bug to Dojox in case someone wants to port it there.

comment:6 Changed 12 years ago by dante

Owner: changed from bill to dante
Status: newassigned

comment:7 Changed 12 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [9660]) ResizeHandle? enhancements fixes #1900 and adds some neat animations to sizing. Calculations are still _slightly_ off but much more accurate than before. now supports activeResizing, and when false, optionally chain/combine a width/height animation to new size.

comment:8 Changed 12 years ago by dante

(In [9661]) fixed oversight when activeResizeNode overlays domNode but is not hidden, preventing typical text-selection within the div. refs #1900

Note: See TracTickets for help on using tickets.