Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#18986 closed defect (fixed)

DnD source prevent text selection when handles are being used.

Reported by: denovichas Owned by: dylan
Priority: high Milestone: 1.9.12
Component: DnD Version: 1.10.8
Keywords: Cc:
Blocked By: Blocking:

Description

onSelectStart() in Container.js doesn't not check for the use of handles and stops the mouse click event from propagation to allows the selection of text for coping. The function should be;

onSelectStart: function(e){
   // summary:
   //    event processor for onselectevent and ondragevent
   // e: Event
   //    mouse event

   if(!this.withHandles && (!this.skipForm || !dnd.isFormElement(e))){
      e.stopPropagation();
      e.preventDefault();
   }
},

Change History (8)

comment:1 Changed 2 years ago by dylan

Milestone: tbd1.12.3
Owner: set to dylan
Priority: undecidedhigh
Status: newassigned

comment:3 Changed 2 years ago by dylans <dylan@…>

Resolution: fixed
Status: assignedclosed

In 7d6cf4d/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 2 years ago by dylans <dylan@…>

In 10daca7/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:5 Changed 2 years ago by dylans <dylan@…>

In c2fcc49/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:6 Changed 2 years ago by dylans <dylan@…>

In ca7103d/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 2 years ago by dylans <dylan@…>

In 0f60616/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:8 Changed 2 years ago by dylan

Milestone: 1.12.31.9.12

Backported to 1.9.x. If we need it earlier, we need a separate patch for earlier versions of Dojo. Thanks!

Note: See TracTickets for help on using tickets.