Opened 3 years ago

Closed 3 years ago

#18980 closed defect (patchwelcome)

dojox.grid._SelectionPreserver loses selection when reselecting a row

Reported by: rlintern Owned by: Evan
Priority: undecided Milestone: 1.12.3
Component: DojoX Grid Version: 1.9.4
Keywords: Cc:
Blocked By: Blocking:

Description

To reproduce:

  1. Create a sortable DataGrid? with keepSelection=true.
  2. Click a row to select it.
  3. Click the same row again (or double-click)
  4. Sort via column header

outcome: Selected row will no longer be highlighted

If I comment out the following line then all works as expected:

connect.connect(selection, 'deselectAll', this, 'reset')

Change History (2)

comment:1 Changed 3 years ago by dylan

Hi @rlintern, fwiw, the dojox DataGrid? has been deprecated for a few years but we'll still accept and land pull requests per our contributing guidelines at ​https://github.com/dojo/dojox/blob/master/CONTRIBUTING.md . If you want to submit a pull request I'll test/review/land it.

comment:2 Changed 3 years ago by dylan

Milestone: tbd → 1.12.3
Resolution: → patchwelcome
Status: new → closed

See earlier note about accepting and reviewing a pull request.

Note: See TracTickets for help on using tickets.