Opened 3 years ago

Closed 3 years ago

#18963 closed defect (worksforme)

Dijit Editor breaks on Firefox 50.1.0 with Dojo 1.11.3 and 1.12

Reported by: himanshug Owned by:
Priority: high Milestone: 1.12.2
Component: Editor Version: 1.12.1
Keywords: Cc:
Blocked By: Blocking:

Description

Dijit Editor does not seem to work on Firefox 50.1.0 with Dojo 1.11.3 and Dojo 1.12.1. It is working fine on Chrome 55.0.2883.87 m. It is also working fine with Dojo 1.10.7.

With Dojo 1.10.7, the Cut, Paste, Copy notification is not shown.

Relevant fiddles:

Dojo 1.12: https://jsfiddle.net/zjp8tucb/2/

Dojo 1.11.3: https://jsfiddle.net/zjp8tucb/3/

Dojo 1.10.7: https://jsfiddle.net/zjp8tucb/4/

Attachments (3)

18963-1.11.3.html (974 bytes) - added by mssskhalsa 3 years ago.
Editor test Dojo 1.11.3
18963-1.12.1.html (974 bytes) - added by mssskhalsa 3 years ago.
Editor test Dojo 1.12.1
18963-1.12.1.2.html (908 bytes) - added by dylan 3 years ago.
asycn loader 1.12.1 test

Download all attachments as: .zip

Change History (11)

comment:1 Changed 3 years ago by dylan

Component: GeneralEditor
Milestone: tbd1.13
Priority: undecidedhigh

comment:2 Changed 3 years ago by himanshug

Update: With Dojo 1.12.1 and Dojo 1.11.3, Editor is not coming up on IE-11 as well.

We are looking to upgrade our Dojo package from 1.10.4 to 1.12.1 but this will cause more problems if Editor does not show up. Is there a workaround to make it work with Dojo 1.12.1 on Firefox and IE?

comment:3 Changed 3 years ago by dylan

Until we have time to diagnose the issue, I cannot recommend a workaround. Best guess is that something we fixed in 1.11.x for the editor caused a regression as the widget is failing to instantiate, though JSFiddle is squelching the debug info.

Looking at Editor commits, https://github.com/dojo/dijit/commit/d9396ec8442ea94d65b70d24a866bd43d62c6539 and https://github.com/dojo/dijit/commit/1561d81cc69eeee83ba1be3545350ff7324b5d60 are probably the first places I would look for what caused the regression.

Changed 3 years ago by mssskhalsa

Attachment: 18963-1.11.3.html added

Editor test Dojo 1.11.3

Changed 3 years ago by mssskhalsa

Attachment: 18963-1.12.1.html added

Editor test Dojo 1.12.1

comment:4 Changed 3 years ago by mssskhalsa

Can you provide a more focused (non-jsfiddle) test? While I can observe problems in the linked fiddles, when I extract the relevant code into the self-contained tests linked above they work fine.

Tested in Windows 10:

  • Firefox 51.0.1 (32-bit)
  • Internet Explorer 11.576.14393.0 (Update Versions 11.0.38)

comment:5 Changed 3 years ago by dylan

Status: newpending

Changed 3 years ago by dylan

Attachment: 18963-1.12.1.2.html added

asycn loader 1.12.1 test

comment:6 Changed 3 years ago by dylan

For what it's worth, I added a 1.12.1 example that uses the proper settings for the async loader to make sure that wasn't the issue... it's not.

My best guess with JS Fiddle is that it's getting confused in http/https mixed mode, or perhaps Dojo 1.11.x+ has broken something cross-domain with the Editor.

himanshug, could you please explain how you are using the Editor, and if the provided example is working for you?

comment:7 Changed 3 years ago by himanshug

Status: pendingnew

Hi dylan, all the examples provided here are working for me. They seem to be broken on JS Fiddle only!

comment:8 Changed 3 years ago by dylan

Milestone: 1.131.12.2
Resolution: worksforme
Status: newclosed

Thanks for letting us know.

Note: See TracTickets for help on using tickets.