Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#18952 closed defect (fixed)

Rendering dtl template problem

Reported by: pinguxx Owned by: dylan
Priority: blocker Milestone: 1.11.4
Component: DojoX DTL Version: 1.12.1
Keywords: Cc:
Blocked By: Blocking:

Description

in _base.js there is a new code on line 551 in the render function

var str = this.contents.resolve(context) || "";

this is making some of the templates render incorrectly since some attributes are passed with 0 and the check above will convert that to empty string

can we change the above to something like this

var str = this.contents.resolve(context);
if (str === undefined || str === null) {
    str = '';
}

that way 0 can still pass

Change History (3)

comment:1 Changed 3 years ago by dylan

Milestone: tbd1.12.2
Owner: changed from Neil Roberts to dylan
Priority: undecidedblocker
Status: newassigned

PR reviewed and approved at https://github.com/dojo/dojox/pull/255 .

comment:2 Changed 3 years ago by dylans <dylan@…>

Resolution: fixed
Status: assignedclosed

In b410697/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:3 Changed 3 years ago by dylan

Milestone: 1.12.21.11.4
Note: See TracTickets for help on using tickets.