Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#18946 closed defect (duplicate)

dojox/form/_BusyButtonMixin Does Not Define 'domConstruct'

Reported by: rpwkDojo Owned by:
Priority: undecided Milestone: 1.12.2
Component: DojoX Form Version: 1.12.1
Keywords: Cc:
Blocked By: Blocking:

Description

In dojox/form/_BusyButtonMixin, function 'setLabel' uses variable 'domConstruct' but the latter is not defined. The (first) array parameter in the 'define' for dojox/form/_BusyButtonMixin should contain "dojo/dom-construct", and the function parameter in the 'define' should contain 'domConstruct' as a function parameter. Without this, BusyButtons? will not work correctly.

The attached file contains the fix.

Attachments (1)

_BusyButtonMixin.js.uncompressed.js (3.7 KB) - added by rpwkDojo 3 years ago.
_BusyButtonMixin.js.uncompressed.js

Download all attachments as: .zip

Change History (3)

Changed 3 years ago by rpwkDojo

_BusyButtonMixin.js.uncompressed.js

comment:1 Changed 3 years ago by dylan

Resolution: duplicate
Status: newclosed

Thanks, this has already been fixed in https://github.com/dojo/dojox/commit/447c7e09ba807251921852c6964a83f960441ed4 , but not yet in a release.

comment:2 Changed 3 years ago by dylan

Milestone: tbd1.12.2
Note: See TracTickets for help on using tickets.