Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#18943 closed defect (fixed)

[regression] dojo/util parseArgs breaking on IE8

Reported by: yohanleafheart Owned by: dylan
Priority: high Milestone: 1.11.4
Component: Core Version: 1.11.3
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

This is a regression from ticket https://bugs.dojotoolkit.org/ticket/18816 . Since ArrayBuffer? and Blob do not exist in IE8 it throws an error when using a POST request with a simple object using dojo/request/xhr. it does not post:

--- Example

require(['dojo/request/xhr'], function (xhr) {
xhr.post(targetUrl, {"handleAs": "json", data: {"a": 1. "b": 2}}).then({
function (result){
console.log(result)
}
});
});

-- Expected behavior

The log should bring the result

-- Actual behavior 'ArrayBuffer?' is undefined Object doesn't support this property or method The exception is generated at dojo/util.js:124

Change History (7)

comment:1 Changed 3 years ago by bill

Description: modified (diff)
Owner: set to dylan
Status: newassigned
Summary: dojo/util parseArgs breaking on IE8[regression] dojo/util parseArgs breaking on IE8

Sounds like [that part of] dojo/request is broken on IE8 in general.

I think IE8 and Windows XP are already EOL, but OTOH https://github.com/dojo/docs/blob/master/releasenotes/1.12.rst#user-agent-support says that dojo still supports IE8.

comment:2 Changed 3 years ago by dylan

Milestone: tbd1.12.2
Priority: undecidedhigh

comment:3 Changed 3 years ago by dylan

@yohanleafheart, please let me know if https://github.com/dojo/dojo/pull/248 solves the issue for you... I'm thinking a simple detection for the presence of native xhr2 would solve the trick, but want to make sure my logic isn't off here. Thanks!

comment:4 Changed 3 years ago by Dylan Schiemann <dylan@…>

Resolution: fixed
Status: assignedclosed

In f61caa8/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:5 Changed 3 years ago by Dylan Schiemann <dylan@…>

In 2fb3f9e/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:6 Changed 3 years ago by Dylan Schiemann <dylan@…>

In 9c3b178/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 3 years ago by dylan

Milestone: 1.12.21.11.4
Note: See TracTickets for help on using tickets.