dojo/i18n: if preload api is disabled, module still attempts to load preload from cache in a build

[mssskhalsa]

If a build is done with a codebase that includes nls resources, then the build cache includes a preload of the form:

'*now':function(r){r(['dojo/i18n!*preload*dojo/nls/dojo*["ar","ca","cs","da","de","el","en-gb","en-us","es-es","fi-fi","fr-fr","he-il","hu","it-it","ja-jp","ko-kr","nl-nl","nb","pl","pt-br","pt-pt","ru","sk","sl","sv","th","tr","zh-tw","zh-cn","ROOT"]']);}

If a consumer of this build disables dojo-preload-i18n-Api in the Dojo config, then the dojo/i18n loader plugin disables preload logic, but still attempts to process the cached preload, which is not a valid module id, so it makes an invalid XHR.

dojo/i18n should probably have a guard against this scenario.

[mssskhalsa]

We are testing a patch for this that seems to work well and will submit a PR if we don't encounter issues.

i18n.js

@@ -255 +255 @@
                                         if(!--remaining){
                                                 load(lang.delegate(cache[loadTarget]));
                                         }
-                                };
+                                },
+                                split = id.split("*"),
+                                preloadDemand = split[1] == "preload";
 
                         if(has("dojo-preload-i18n-Api")){
-                                var split = id.split("*"),
-                                        preloadDemand = split[1] == "preload";
                                 if(preloadDemand){
                                         if(!cache[id]){
                                                 // use cache[id] to prevent multiple preloads of the same preload; this shouldn't happen, but
@@ -274 +274 @@
                                         return;
                                 }
                         }
+                        else if(preloadDemand) {
+                                // If a build is created with i18n resources and 'dojo-preload-i18n-Api' has not been set to false,
+                                // the built file will include a preload in the cache (which looks about like so:)
+                                // '*now':function(r){r(['dojo/i18n!*preload*dojo/nls/dojo*["ar","ca","cs","da","de","el","en-gb","en-us","es-es","fi-fi","fr-fr","he-il","hu","it-it","ja-jp","ko-kr","nl-nl","nb","pl","pt-br","pt-pt","ru","sk","sl","sv","th","tr","zh-tw","zh-cn","ROOT"]']);}
+                                // If the consumer of the build sets 'dojo-preload-i18n-Api' to false in the Dojo config, the cached
+                                // preload will not be parsed and will result in an attempt to call 'require' passing it the unparsed
+                                // preload, which is not a valid module id.
+                                // In this case we should skip this request.
+                                load(1);
+
+                                return;
+                        }
 
                         array.forEach(loadList, function(locale){
                                 var target = bundlePathAndName + "/" + locale;

[mssskhalsa]

​1.11 PR

​master PR

[Dylan Schiemann <[email protected]…>]

In 598c215/dojo:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Dylan Schiemann <[email protected]…>]

In 36956c4/dojo:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Dylan Schiemann <[email protected]…>]

In 00f5aea7/dojo:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Dylan Schiemann <[email protected]…>]

In b073106/dojo:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?