Opened 2 years ago

Last modified 18 months ago

#18921 new defect

Wrong calculation of FilteringSelect width

Reported by: Denis Rykov Owned by:
Priority: undecided Milestone: 1.14
Component: Dijit - Form Version: 1.12.0-rc2
Keywords: Cc:
Blocked By: Blocking:

Description

We are using dojox/layout/TableContainer which contains two widgets: dijit/form/Select and dijit/form/FilteringSelect with the same width (style: "width: 50%"). Here is jsfidle. As you can see width of widget is not the same. FilteringSelect? is wider than Select:

http://i.imgur.com/FBRaMTM.png

It looks like the following CSS able to fix this issue, but I'm not sure this is the right solution:

.claro .dijitTextBox{
  box-sizing: border-box;
}

Change History (5)

comment:1 Changed 2 years ago by dylan

Milestone: tbd1.12

Will aim to address this with 1.12, though it may slip to 1.12.1 and similar backports.

comment:2 Changed 2 years ago by Denis Rykov

It seems that the root cause of this issue is the different markup of the same elements within widgets. Select is based on <table>, but FilteringSelect? on <div>. Is this done intentionally?

comment:3 Changed 2 years ago by dylan

Years ago it was indeed done intentionally to deal with issues of old IE... it's probably not necessary any longer, but we also don't want to break forwards compatibility within the 1.x releases whenever possible.

comment:4 Changed 2 years ago by dylan

Milestone: 1.121.13

comment:5 Changed 18 months ago by dylan

Milestone: 1.131.14
Note: See TracTickets for help on using tickets.