Opened 13 years ago

Closed 13 years ago

#1891 closed enhancement (fixed)

AccordionPane label style class should be more distinct

Reported by: guest Owned by: dante
Priority: high Milestone: 0.9
Component: Dijit Version: 0.4
Keywords: AccordionPane widget style class Cc:
Blocked By: Blocking:

Description

The style class for labels in the AccordionPane? widget is .label, seems to me that is too common of a class name. I would suggest something like .dojoAccordionPaneLabel to go with .dojoAccordionPane, should cause fewer conflicts.

Change History (8)

comment:1 Changed 13 years ago by guest

Actually, maybe it would make more sense to make it .accLabel, similar to .accBody for the body of the AccordionPane?.

comment:2 Changed 13 years ago by bill

Milestone: → 0.5

Hmm, the idea was to have CSS rules like 

.dojoAccordion .label { ... }

No good?

comment:3 Changed 13 years ago by guest

No good when you already have a .label style rule.

comment:4 Changed 13 years ago by Adam Peller

Component: Widgets → Dijit
Owner: changed from bill to koranteng

comment:5 Changed 13 years ago by Adam Peller

Owner: changed from koranteng to Adam Peller

comment:6 Changed 13 years ago by Adam Peller

Owner: changed from Adam Peller to dante

should be a gimme... just not sure what the right conventions are for our css

comment:7 Changed 13 years ago by dante

Status: new → assigned

comment:8 Changed 13 years ago by dante

Resolution: → fixed
Status: assigned → closed

(In [9733]) refs #3661 (icon tundra unity) and fixes #3820 #3822 and #1891

Note: See TracTickets for help on using tickets.