Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#18906 closed defect (fixed)

Can no longer set a DOM node as the target of a Standby

Reported by: jandockxppw Owned by: dylan
Priority: high Milestone: 1.11.3
Component: Dojox Version: 1.11.2
Keywords: Cc:
Blocked By: Blocking:

Description

In commit https://github.com/dojo/dojox/commit/8f016dc0b5c6141eb1c2533ca2c3d4d343f7d107, which is intended to fix #16544 (enhancement), a setter for target is introduced. This setter selects a DOM node as target, given a string as dijit registry id or element id, if the setter argument is a string.

Note that there is no else branch. For any other type of argument, we now do nothing, silently!

Originally, setting the target of Standby required passing a DOM node, and we have code that does that. Now, that doesn't work anymore. We get an error on "show", because there is no target, although we did call set("target", node).

I believe that this cannot have been the intention. There should be an else branch that just sets the target if the argument is not a string, at least.

Change History (5)

comment:3 Changed 3 years ago by dylans <dylan@…>

Resolution: fixed
Status: newclosed

In d64bb47/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 3 years ago by dylans <dylan@…>

In fe410d3/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:5 Changed 3 years ago by dylan

Milestone: tbd1.11.3
Priority: undecidedhigh
Note: See TracTickets for help on using tickets.