Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#18865 closed defect (fixed)

dojox/dtl render change

Reported by: pinguxx Owned by: Neil Roberts
Priority: undecided Milestone: 1.12
Component: DojoX DTL Version: 1.11.2
Keywords: Cc:
Blocked By: Blocking:

Description

I use django template for a lot of my widgets i notice this change on dojox/dtl/tag/logic.js, line 137 from arred.push(items[key]); to arred.push([key, items[key]]);

all the places that i have loops are now broken since im referencing the first parameter and its no longer the object

example code

{% for successmsg in success.messages %}
    <span data-alerts-id="{{successmsg.id}}{{successmsg.message|safe}}</span>
{% endfor %}

Change History (8)

comment:1 Changed 3 years ago by dylan

Yes, https://github.com/dojo/dojox/commit/1dcf38ea5f15079355ac20df0b372753da9dd6bc was made to fix #17251 . The change was made to increase compatibility with the Django template system.

comment:2 Changed 3 years ago by pinguxx

well, can this be (object, key), so it doesn't break backwards compatibility?

Last edited 3 years ago by pinguxx (previous) (diff)

comment:3 Changed 3 years ago by dylan

Milestone: tbd1.12

We'll make a decision before we ship 1.12.

comment:4 Changed 3 years ago by Michael Van Sickle <mvansickle@…>

Resolution: fixed
Status: newclosed

In 5099079/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:5 Changed 3 years ago by Michael Van Sickle <mvansickle@…>

In 88aec42/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:6 Changed 3 years ago by dylans <dylan@…>

In b7607e5/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 3 years ago by dylans <dylan@…>

In 8594124/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:8 Changed 3 years ago by dylans <dylan@…>

In c4b15c4/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.