Opened 3 years ago

Closed 3 years ago

#18849 closed enhancement (fixed)

dijitTabPane css class not removed from TabContainer child when removeChild is called

Reported by: fin-ger Owned by: bill
Priority: undecided Milestone: 1.11.3
Component: Dijit Version: 1.11.1
Keywords: Cc:
Blocked By: Blocking:

Description

Removing a child widget from a TabContainer? and adding this widget to a BorderContainer? results in appearance issues, as the dijitTabPane class is still present in the child.

When manually removing the class between the removeChild and the addChild everything works as expected.

As the addChild method of the TabContainer? adds css styles to the child widget I would expect the removeChild method to remove those css styles from the child widget.

Change History (5)

comment:1 Changed 3 years ago by dylan

Milestone: tbd → 1.11.3

comment:2 Changed 3 years ago by Michael J Van Sickle

Submitted PR 119 (​https://github.com/dojo/dijit/pull/119) to correct this issue.

comment:3 Changed 3 years ago by Michael J Van Sickle

Resolution: → fixed
Status: new → closed

comment:4 Changed 3 years ago by dylan

Resolution: fixed
Status: closed → reopened

Re-opened, as I don't consider things fixed until they've landed in master! :)

comment:5 Changed 3 years ago by Michael Van Sickle <mvansickle@…>

Resolution: → fixed
Status: reopened → closed

In c198a11/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?
Note: See TracTickets for help on using tickets.