#18830 closed defect (fixed)
"npm run test-local" hangs in dom-construct test
Reported by: | bill | Owned by: | |
---|---|---|---|
Priority: | undecided | Milestone: | 1.11.3 |
Component: | Core | Version: | 1.11.1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Starting with 2c3e8d1fd090bbc7ca753392bc2a1f7c2495d475 the unit tests hang in the dom-construct test.
I saw the problem on mac. I first ran "chromedriver" and then ran "npm run test-local".
I think the problem is with the test clearing all of document.body, on the line:
function clearTarget() { document.body.innerHTML = ""; ...
But just removing that lines causes test failures.
The test should be creating a container node and working inside of that, like dom-prop does:
var container; registerSuite({ name: 'dojo/dom-prop', setup: function () { container = document.createElement("div"); document.body.appendChild(container); }, teardown: function () { document.body.removeChild(container); },
Change History (5)
comment:1 Changed 5 years ago by
comment:2 Changed 4 years ago by
Milestone: | tbd → 1.12 |
---|
comment:3 Changed 4 years ago by
Owner: | set to Dylan Schiemann <[email protected]…> |
---|---|
Resolution: | → fixed |
Status: | new → closed |
In 40221c7/dojo:
comment:5 Changed 4 years ago by
Milestone: | 1.12 → 1.11.3 |
---|
Note: See
TracTickets for help on using
tickets.
In 0c5cc58/dojo: