Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#18830 closed defect (fixed)

"npm run test-local" hangs in dom-construct test

Reported by: bill Owned by: Dylan Schiemann <dylan@…>
Priority: undecided Milestone: 1.11.3
Component: Core Version: 1.11.1
Keywords: Cc:
Blocked By: Blocking:

Description

Starting with 2c3e8d1fd090bbc7ca753392bc2a1f7c2495d475 the unit tests hang in the dom-construct test.

I saw the problem on mac. I first ran "chromedriver" and then ran "npm run test-local".

I think the problem is with the test clearing all of document.body, on the line:

 function clearTarget() {
       document.body.innerHTML = "";
       ...

But just removing that lines causes test failures.

The test should be creating a container node and working inside of that, like dom-prop does:

var container;

registerSuite({
    name: 'dojo/dom-prop',
    setup: function () {
        container = document.createElement("div");
        document.body.appendChild(container);
    },
    teardown: function () {
        document.body.removeChild(container);
    },

Change History (5)

comment:1 Changed 4 years ago by Bill Keese <bill@…>

In 0c5cc58/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:2 Changed 3 years ago by dylan

Milestone: tbd1.12

comment:3 Changed 3 years ago by Dylan Schiemann <dylan@…>

Owner: set to Dylan Schiemann <dylan@…>
Resolution: fixed
Status: newclosed

In 40221c7/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 3 years ago by Dylan Schiemann <dylan@…>

In a9301c8/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:5 Changed 3 years ago by dylan

Milestone: 1.121.11.3
Note: See TracTickets for help on using tickets.