Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#1881 closed defect (fixed)

dojo.lfx.html.explode can cause exception

Reported by: ornus Owned by: Bryan Forbes
Priority: high Milestone:
Component: lfx Version: 0.4
Keywords: lfx.html Cc: sol@…
Blocked By: Blocking:

Description

dojo.lfx.html.explode expects the 1st argument ("start") to be a DOM node. However the method sometimes is called with no start or end nodes being replaced by an object holding coordinates. For example dojo.lfx.toggle.explode can pass such an object.

dojo.lfx.html.explode looks for style in the "start" argument. If there's no such attribute an *null* exception will be thrown.

To see the problem open "testswidget est_Menu2.html" and right-click on the tree. A context menu should be shown, but exception is thrown instead.

Attachments (2)

lfx.html.1​ (630 bytes) - added by ornus 13 years ago.
Proposed fix.
lfx.html.1.patch​ (630 bytes) - added by ornus 13 years ago.
Proposed fix with corrected extension.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 13 years ago by ornus

I'm sorry, mistyped test case url. To reproduce the problem open "testswidget reeV3menu1.html" and right-click on the tree.

Changed 13 years ago by ornus

Attachment: lfx.html.1​ added

Proposed fix.

Changed 13 years ago by ornus

Attachment: lfx.html.1.patch​ added

Proposed fix with corrected extension.

comment:2 Changed 13 years ago by Bryan Forbes

Resolution: → fixed
Status: new → closed

(In [6525]) Fixes exception when a null is passed in for start. Fixes #1881.

comment:3 Changed 13 years ago by Bryan Forbes

Resolution: → fixed

(In [6529]) Fixes exception when null is passed in for starting node in explode. Fixes #1881.

comment:4 Changed 13 years ago by (none)

Milestone: 0.4.1

Milestone 0.4.1 deleted

Note: See TracTickets for help on using tickets.